exclude third_party files from running unit tests #6012
Conversation
This commit adds unit_tests() to presubmit-tests.sh to exclude running unit tests on files in thirt_party. This can help to avoid getting errors in the thirt_party folder. This commits also update the third_party folder to validate that this change takes effect. Signed-off-by: Yongxuan Zhang [email protected]
|
Skipping CI for Draft Pull Request. |
tekton-robot
added
do-not-merge/work-in-progress
tekton-robot
added
the
size/S
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test all |
|
/retest |
tekton-robot
added
size/M
|
/test all |
|
/test all |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| case LeveledLogger: | ||
| v.Debug("performing request", "method", req.Method, "url", req.URL) | ||
| case Logger: | ||
| v.Printf("[DEBUG] %s %s", req.Method, req.URL) |
Check failure
Code scanning / CodeQL
Log entries created from user input
| case LeveledLogger: | ||
| v.Error("request failed", "error", err, "method", req.Method, "url", req.URL) | ||
| case Logger: | ||
| v.Printf("[ERR] %s %s request failed: %v", req.Method, req.URL, err) |
Check failure
Code scanning / CodeQL
Log entries created from user input
| case LeveledLogger: | ||
| v.Debug("retrying request", "request", desc, "timeout", wait, "remaining", remain) | ||
| case Logger: | ||
| v.Printf("[DEBUG] %s: retrying in %s (%d left)", desc, wait, remain) |
Check failure
Code scanning / CodeQL
Log entries created from user input
| // the caller knows no overflow occurred. | ||
| func SafeParseInt(in interface{}) (int, error) { | ||
| raw, err := SafeParseIntRange(in, math.MinInt, math.MaxInt) | ||
| return int(raw), err |
Check failure
Code scanning / CodeQL
Incorrect conversion between integer types
|
|
||
| var result = make([]int, 0, len(raw)) | ||
| for _, element := range raw { | ||
| result = append(result, int(element)) |
Check failure
Code scanning / CodeQL
Incorrect conversion between integer types
| remainingIfAddrs := make(IfAddrs, 0, len(ifAddrs)) | ||
|
|
||
| rfcNetMap := KnownRFCs() | ||
| rfcNets, ok := rfcNetMap[uint(inputRFC)] |
Check failure
Code scanning / CodeQL
Incorrect conversion between integer types
| return IfAddrs{}, IfAddrs{}, fmt.Errorf("mask size out of bounds for IPv6 address: %d", maskSize) | ||
| } | ||
|
|
||
| if (*ipAddr).Maskbits() == int(maskSize) { |
Check failure
Code scanning / CodeQL
Incorrect conversion between integer types
|
|
||
| ipv4 := *ToIPv4Addr(inputIfAddr.SockAddr) | ||
| ipv4Uint32 := uint32(ipv4.Address) | ||
| ipv4Uint32 += uint32(i) |
Check failure
Code scanning / CodeQL
Incorrect conversion between integer types
| wrappedMask = 1 + i + int64(^uint32(ipv4.Mask)) | ||
| } | ||
|
|
||
| ipv4Uint32 = ipv4Uint32 + (uint32(wrappedMask) &^ uint32(ipv4.Mask)) |
Check failure
Code scanning / CodeQL
Incorrect conversion between integer types
|
/retest-required |
|
@Yongxuanzhang: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Fixed in #6416 |
Changes
This commit adds unit_tests() to presubmit-tests.sh to exclude running unit tests on files in thirt_party. This can help to avoid getting errors in the thirt_party folder. This commits also update the third_party folder to validate that this change takes effect.
/kind misc
Signed-off-by: Yongxuan Zhang [email protected]
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes