Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix null handling for trustServerCertificate and readOnlyIntent config options #818

Merged
merged 1 commit into from
Oct 30, 2018

Conversation

arthurschreiber
Copy link
Collaborator

These two options should not treat null values like undefined either. This was deprecated before v4.x but the behaviour was not changed correctly when v4.0.0 was released.

`trustServerCertificate` and `readOnlyIntent` should not ignore passed 
null values either.
@arthurschreiber arthurschreiber merged commit 7127183 into master Oct 30, 2018
@arthurschreiber arthurschreiber deleted the arthur/fix-config-checks branch October 30, 2018 06:29
@arthurschreiber
Copy link
Collaborator Author

🎉 This PR is included in version 4.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant