-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update dependencies #71
Conversation
ba26a33
to
f5141b5
Compare
f5141b5
to
97575c3
Compare
tag: imageTag, | ||
tagOrDigest: imageTag, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a deprecation warning about tag
property - this is the replacement.
command: npm run unit-test | ||
command: npm run jest-unit-test -- --ci --maxWorkers=2 | ||
- run: | ||
name: Run infra tests | ||
command: npm run infra-test | ||
command: npm run jest-infra-test -- --ci --maxWorkers=2 | ||
- run: | ||
name: Run integration tests | ||
command: npm run integration-test | ||
command: npm run jest-integration-test -- --ci --maxWorkers=2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed it to call jest directly so we don't run build
with each. Also, saw weird issues with jest workers being killed in CircleCI, so reduced number of maxWorkers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How many workers was it running by default?
declare type ParsedArn = { | ||
type ParsedArn = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change happened automatically.
expect(err.message).toBe("Request failed with status code 401"); | ||
expect((err as Error).message).toBe( | ||
"Request failed with status code 401" | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needed to add as Error
to keep TypeScript happy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That all looks reasonable. Nice one.
🎉 This PR is included in version 2.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Update all dependencies to their latest versions
Should resolve the following in projects: