Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update dependencies #71

Merged
merged 3 commits into from
Apr 25, 2023
Merged

feat: update dependencies #71

merged 3 commits into from
Apr 25, 2023

Conversation

mrliptontea
Copy link
Member

@mrliptontea mrliptontea changed the title chore: update dependencies feat: update dependencies Apr 24, 2023
@mrliptontea mrliptontea force-pushed the chore_update_dependencies branch 2 times, most recently from ba26a33 to f5141b5 Compare April 24, 2023 20:40
@mrliptontea mrliptontea force-pushed the chore_update_dependencies branch from f5141b5 to 97575c3 Compare April 24, 2023 21:47
tag: imageTag,
tagOrDigest: imageTag,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was a deprecation warning about tag property - this is the replacement.

Comment on lines -109 to +115
command: npm run unit-test
command: npm run jest-unit-test -- --ci --maxWorkers=2
- run:
name: Run infra tests
command: npm run infra-test
command: npm run jest-infra-test -- --ci --maxWorkers=2
- run:
name: Run integration tests
command: npm run integration-test
command: npm run jest-integration-test -- --ci --maxWorkers=2
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed it to call jest directly so we don't run build with each. Also, saw weird issues with jest workers being killed in CircleCI, so reduced number of maxWorkers.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How many workers was it running by default?

declare type ParsedArn = {
type ParsedArn = {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change happened automatically.

Comment on lines -116 to +118
expect(err.message).toBe("Request failed with status code 401");
expect((err as Error).message).toBe(
"Request failed with status code 401"
);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needed to add as Error to keep TypeScript happy.

Copy link
Member

@kiyanwang kiyanwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That all looks reasonable. Nice one.

@mrliptontea mrliptontea merged commit faaf5be into main Apr 25, 2023
@mrliptontea mrliptontea deleted the chore_update_dependencies branch April 25, 2023 11:15
@talisaspire
Copy link
Collaborator

🎉 This PR is included in version 2.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants