Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for ARM instances #772

Closed
garrygerber opened this issue Jul 27, 2021 · 8 comments
Closed

support for ARM instances #772

garrygerber opened this issue Jul 27, 2021 · 8 comments
Labels
enhancement New feature or request ops Need a ops update (k8s, helm, docker)

Comments

@garrygerber
Copy link
Contributor

add docker support for ARM instances

@tchiotludo
Copy link
Owner

@garrygerber : maybe you can help here ?
I'm not aware of Docker with ARM since I'm not using it.
PR are welcome here

@tchiotludo tchiotludo added enhancement New feature or request ops Need a ops update (k8s, helm, docker) labels Jul 29, 2021
@raphaelauv
Copy link
Contributor

@garrygerber
Copy link
Contributor Author

garrygerber commented Sep 27, 2021

@tchiotludo from a code review, I see that the Dockerfile you have already support multi-arch
the only change needed is to use the "docker buildx" command instead of "docker build" and specify the arch's with the "platforms" flag.
I couldn't find the code that is responsible for the build to patch it but if you point me to it maybe I can PR it

@tchiotludo
Copy link
Owner

The build is here :

- name: Publish to Docker Hub
uses: elgohr/Publish-Docker-Github-Action@master
if: github.ref == 'refs/heads/dev' || startsWith(github.ref, 'refs/tags/')
with:
name: tchiotludo/akhq
username: ${{ secrets.DOCKERHUB_USERNAME }}
password: ${{ secrets.DOCKERHUB_PASSWORD }}
tag_names: true

. I think you will need to replace a old github action with the official one that support buildx

@garrygerber
Copy link
Contributor Author

@tchiotludo can you create an official release that includes this enhancement?
even a patch would be appreciated (0.18.1 for example)
thanks!

@tchiotludo
Copy link
Owner

tchiotludo commented Sep 30, 2021

I'll try to have some time to release it next week 🙂
Have you tried ? I don't have any arm to test 😅

@garrygerber
Copy link
Contributor Author

I've run it with the dev tag and it looks good, but you should still do your testing that you're used too

tchiotludo pushed a commit that referenced this issue Oct 24, 2021
@tchiotludo
Copy link
Owner

Lot of weeks later, release happen 😄

@tchiotludo tchiotludo moved this to Done in Backlog Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ops Need a ops update (k8s, helm, docker)
Projects
Status: Done
Development

No branches or pull requests

3 participants