-
-
Notifications
You must be signed in to change notification settings - Fork 665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy-Topic behaviour when destination is source #745
Comments
Good report ! thanks :)
|
I'm planning on using the same feature as @HailToDodongo mentioned, so the option "prevent the same destination topic" wouldn't work for me. I'd like to re-initialise my system in the morning or if something goes wrong. |
This is a MAJOR BUG that caused A LOT of troubles where I work, many hours searching for the cause of message duplications and GBs of data being loaded in a topic coming out nowhere that created a cascade of other issues in other systems. We figured out someone used that "feature", probably by accident... and it created a feedback loop. We were "lucky" this wasn't in production. I hope this is being prioritized to TOP LEVEL BUG with possible MAJOR IMPACT on organizations. I recommend all people reading this to block the route to that form in your ingress if you can, because to make matters worse, there's no way to revoke access to this without removing data/write completely. I also highly suggest you implement much more granular access control on features that are added to current roles. Write access shouldn't include "copy". |
@archetec maybe your company could contribute to this easy fix, it will be simplest than report with caps lock 🙃 |
I agree and totally understand you view point. Unfortunately the company I work for doesn't allow this. Not my decision. As a subcontractor I could do something on my own, but TBH I haven't spent much time coding in Java in the last 15 years so.... yeah. There's that. The all caps and bold was to warn others of the possibility of major problems in production:
TBH, if this was my project, I would release a "quick fix" and deactivate the feature until it is fixed. IMHO, it is that bad. I understand open source projects, and how the software is provided "as is", but as a community, this kind of bug should be top priority. |
@archetec I have to disagree on that, it's not an all-caps major bug. For me, putting AKHQ in an production environment and letting people use it, is the equivalent of giving someone a root-mysql shell on a production database without transactions. What i'm getting at is: AKHQ (when writing data) can be dangerous and you should have some mechanism or fail-safes to stop it when necessary, especially when you do this more often. Sorry if i sound a bit angry, but i just don't like it when people scream at open source projects without contributing. Btw, my workaround for now is to create a temporary dummy topic where i copy the data to, to then copy it back to the original topic. |
Thanks @HailToDodongo for the explanation !! ❤️ If you are a company using open source software, made by personal people, you just couldn't expect professional support that allow you to use bold and caps lock on issue that could be solved with few hours of works. Just open a PR to solve the issue on your personal time, like the whole software was built. AKHQ was built because I need a soft like that and I couldn't find that at this time, on my personal time and offer free to all people. Just keep in mind open source is hard work with no support from most companies that are using it and don't pay for it (look at my sponsor page on GitHub...). Sending caps lock comment don't help me personally to continue this project, PR on YOUR personal time help more 🤪 |
Well, I wasn't screaming, sorry if it came through like this, it wasn't my intention. I'm also very sorry for not contributing to the project. I'm not going to debate further as I don't think it's contributing to anything. It's noted that we are on our own with this issue for the moment and will review our usage of AKHQ for production support. I understand your position and thank you for your work on this project, and the same to all contributors. AKHQ is a great tool, we just need to adjust. |
So for now copying onto the same topic is disabled; one can use an intermediate topic for duplication to prevent an endless loop. |
While using the new "Copy Topic" feature, i tried to copy a topic to itself.
My intention was to duplicate the data, but it ended up filling it without stopping.
I guess copying works by streaming, and it will copy the already copied data again and again.
Depending on the kafka setup this can be dangerous since the only way i could stop this was by killing the akhq container.
IMO either the UI should prevent self-copies, or fall back to a non-streamed copy.
The text was updated successfully, but these errors were encountered: