Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Endpoint topic/{topicName}/groups incorrect acl resource type [0.25.0] #1789

Closed
doxsch opened this issue May 27, 2024 · 1 comment · Fixed by #1796
Closed

Endpoint topic/{topicName}/groups incorrect acl resource type [0.25.0] #1789

doxsch opened this issue May 27, 2024 · 1 comment · Fixed by #1796
Labels
bug Something isn't working login Login & Acls on AKHQ

Comments

@doxsch
Copy link
Contributor

doxsch commented May 27, 2024

In the TopicController, it appears that the wrong resource is being checked for the endpoint api/{cluster}/topic/{topicName}/groups (see here). Instead of using Role.Resource.TOPIC, it might be more appropriate to use Role.Resource.CONSUMER_GROUP, as the same data can be read in the GroupController with the CONSUMER_GROUP resource (see here).
@github-project-automation github-project-automation bot moved this to Backlog in Backlog May 27, 2024
@tchiotludo
Copy link
Owner

@doxsch PR are welcome :)

@tchiotludo tchiotludo added bug Something isn't working login Login & Acls on AKHQ labels May 27, 2024
doxsch added a commit to doxsch/akhq that referenced this issue May 27, 2024
@doxsch
fix: endpoint topic/{topicName}/groups incorrect acl resource type
b87b332 
closes tchiotludo#1789
@doxsch doxsch mentioned this issue May 27, 2024
Merged
tchiotludo pushed a commit that referenced this issue May 27, 2024
@doxsch
fix(auth): endpoint topic/{topicName}/groups incorrect acl resource t…
21d360f 
…ype (#1796)

closes #1789
@github-project-automation github-project-automation bot moved this from Backlog to Done in Backlog May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working login Login & Acls on AKHQ
Projects
Backlog
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: endpoint topic/{topicName}/groups incorrect acl resource type doxsch/akhq
2 participants
@tchiotludo @doxsch