Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normative: GetFunctionRealm may throw on revoked proxies #356

Merged
merged 2 commits into from
Jun 6, 2022

Conversation

legendecas
Copy link
Member

@legendecas legendecas commented Mar 29, 2022

This is a revisit of #349.

GetFunctionRealm may throw if the target function is a revoked proxy. This PR adds changes that make sure thrown error is created in the realm in which the wrapped function is created. The steps mirror the steps in https://tc39.es/ecma262/#sec-ecmascript-function-objects-call-thisargument-argumentslist.

/cc @syg @erights

1. Let _target_ be _F_.[[WrappedTargetFunction]].
1. Assert: IsCallable(_target_) is *true*.
1. Let _targetRealm_ be ? GetFunctionRealm(_target_).
1. Let _callerRealm_ be ? GetFunctionRealm(_F_).
1. Let _calleeContext_ be PrepareForWrappedFunctionCall(_F_).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, initially I had something similar to this, and after some back and forward with @syg, we decided that this was not necessary. I will try to dig that discussing out from some of the earlier PRs.

spec.html Show resolved Hide resolved
@leobalter leobalter merged commit 5a3aae8 into tc39:main Jun 6, 2022
@legendecas legendecas deleted the get-function-realm branch June 7, 2022 00:33
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Oct 31, 2022
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Oct 31, 2022
jamienicol pushed a commit to jamienicol/gecko that referenced this pull request Nov 11, 2022
jamienicol pushed a commit to jamienicol/gecko that referenced this pull request Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants