-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Normative: GetFunctionRealm may throw on revoked proxies #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caridy
reviewed
Mar 31, 2022
1. Let _target_ be _F_.[[WrappedTargetFunction]]. | ||
1. Assert: IsCallable(_target_) is *true*. | ||
1. Let _targetRealm_ be ? GetFunctionRealm(_target_). | ||
1. Let _callerRealm_ be ? GetFunctionRealm(_F_). | ||
1. Let _calleeContext_ be PrepareForWrappedFunctionCall(_F_). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well, initially I had something similar to this, and after some back and forward with @syg, we decided that this was not necessary. I will try to dig that discussing out from some of the earlier PRs.
caridy
reviewed
Mar 31, 2022
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Oct 31, 2022
This implements the changes from <tc39/proposal-shadowrealm#356>. Depends on D160511 Differential Revision: https://phabricator.services.mozilla.com/D160512
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Oct 31, 2022
This implements the changes from <tc39/proposal-shadowrealm#356>. Depends on D160511 Differential Revision: https://phabricator.services.mozilla.com/D160512
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Nov 11, 2022
This implements the changes from <tc39/proposal-shadowrealm#356>. Depends on D160511 Differential Revision: https://phabricator.services.mozilla.com/D160512
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Nov 11, 2022
This implements the changes from <tc39/proposal-shadowrealm#356>. Depends on D160511 Differential Revision: https://phabricator.services.mozilla.com/D160512
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a revisit of #349.
GetFunctionRealm may throw if the target function is a revoked proxy. This PR adds changes that make sure thrown error is created in the realm in which the wrapped function is created. The steps mirror the steps in https://tc39.es/ecma262/#sec-ecmascript-function-objects-call-thisargument-argumentslist.
/cc @syg @erights