Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add format-id-fn and format-msg-fn to signal-preamble-fn params #34

Closed
wants to merge 1 commit into from
Closed

add format-id-fn and format-msg-fn to signal-preamble-fn params #34

wants to merge 1 commit into from

Conversation

Knotschi
Copy link
Contributor

This way its easier to reuse signal-preamble-fn for custom handlers.
If nil is passed as any format fn: value won't be logged.
The - char before the msg is now part of the formatter fn.

@Knotschi
add format-id-fn and format-msg-fn to signal-preamble-fn params
dfcfad3 
This way its easier to reuse signal-preamble-fn for custom handlers.
If nil is passed as any format fn: value won't be logged.
The `-` char before the msg is now part of the formatter fn.
@ptaoussanis ptaoussanis self-assigned this Nov 27, 2024
@ptaoussanis ptaoussanis added the enhancement New feature or request label Nov 27, 2024
@ptaoussanis ptaoussanis added this to the v1 final milestone Nov 27, 2024
ptaoussanis pushed a commit that referenced this pull request Nov 27, 2024
@Knotschi @ptaoussanis
[new] [#34] Add new signal-preamble-fn opts (@Knotschi)
77547ed 
New opts:

  - `:format-id-fn`
  - `:format-msg-fn`

This way its easier to reuse signal-preamble-fn for custom handlers.
If nil is passed as any format fn: value won't be logged.
The `-` char before the msg is now part of the formatter fn.
@ptaoussanis
Copy link
Member

Thanks! Merged manually 👍

ptaoussanis pushed a commit that referenced this pull request Dec 20, 2024
@Knotschi @ptaoussanis
[new] [#34] Add new signal-preamble-fn opts (@Knotschi)
1c7431a 
New opts:

  - `:format-id-fn`
  - `:format-msg-fn`

This way its easier to reuse signal-preamble-fn for custom handlers.
If nil is passed as any format fn: value won't be logged.
The `-` char before the msg is now part of the formatter fn.
ptaoussanis pushed a commit that referenced this pull request Dec 20, 2024
@Knotschi @ptaoussanis
[new] [#34] Add new signal-preamble-fn opts (@Knotschi)
9dc229d 
New opts:

  - `:format-id-fn`
  - `:format-msg-fn`

This way its easier to reuse signal-preamble-fn for custom handlers.
If nil is passed as any format fn: value won't be logged.
The `-` char before the msg is now part of the formatter fn.
ptaoussanis pushed a commit that referenced this pull request Dec 20, 2024
@Knotschi @ptaoussanis
[new] [#34] Add new signal-preamble-fn opts (@Knotschi)
4d57dcc 
New opts:

  - `:format-id-fn`
  - `:format-msg-fn`

This way its easier to reuse signal-preamble-fn for custom handlers.
If nil is passed as any format fn: value won't be logged.
The `-` char before the msg is now part of the formatter fn.
ptaoussanis pushed a commit that referenced this pull request Dec 22, 2024
@Knotschi @ptaoussanis
[new] [#34] Add new signal-preamble-fn opts (@Knotschi)
e62d0ce 
New opts:

  - `:format-id-fn`
  - `:format-msg-fn`

This way its easier to reuse signal-preamble-fn for custom handlers.
If nil is passed as any format fn: value won't be logged.
The `-` char before the msg is now part of the formatter fn.
ptaoussanis pushed a commit that referenced this pull request Dec 22, 2024
@Knotschi @ptaoussanis
[new] [#34] Add new signal-preamble-fn opts (@Knotschi)
0822217 
New opts:

  - `:format-id-fn`
  - `:format-msg-fn`

This way its easier to reuse signal-preamble-fn for custom handlers.
If nil is passed as any format fn: value won't be logged.
The `-` char before the msg is now part of the formatter fn.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ptaoussanis ptaoussanis

Labels
enhancement New feature or request
Projects
None yet
Milestone
v1 final
Development

Successfully merging this pull request may close these issues.
2 participants
@Knotschi @ptaoussanis