aarch64: Use CASP instead of LDXP/STXP for load if available #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taiki-e
added
the
O-arm
|
Ah, it seems that there is the (unreviewed) similar patch in LLVM (https://reviews.llvm.org/D110069) |
taiki-e
force-pushed
the
casp
branch
4 times, most recently
from
cbad42c to
5712ce5
Compare
taiki-e
changed the title
|
This improves load performance but does not seem to improve RMW and store performance (on AWS Graviton2). https://cirrus-ci.com/task/5305441004552192 |
|
bors r+ |
taiki-e
added a commit
to taiki-e/atomic-maybe-uninit
that referenced
this pull request
Aug 3, 2022
bors bot
added a commit
that referenced
this pull request
Feb 5, 2023
70: aarch64: Use CASP instead of LDXP/STXP for store/RMW if available r=taiki-e a=taiki-e Follow-up #20 In #20, we postponed this (#20 (comment)), but LLVM 16+ adopted this (llvm/llvm-project@10d34f5), so we'll follow LLVM's behavior. Co-authored-by: Taiki Endo <[email protected]>
bors bot
added a commit
that referenced
this pull request
Feb 5, 2023
70: aarch64: Use CASP instead of LDXP/STXP for store/RMW if available r=taiki-e a=taiki-e Follow-up #20 In #20, we postponed this (#20 (comment)), but LLVM 16+ adopted this (llvm/llvm-project@10d34f5), so we'll follow LLVM's behavior. Co-authored-by: Taiki Endo <[email protected]>
bors bot
added a commit
that referenced
this pull request
Feb 6, 2023
70: aarch64: Use CASP instead of LDXP/STXP for store/RMW if available r=taiki-e a=taiki-e Follow-up #20 In #20, we postponed this (#20 (comment)), but LLVM 16+ adopted this (llvm/llvm-project@10d34f5), so we'll follow LLVM's behavior. Co-authored-by: Taiki Endo <[email protected]>
taiki-e
added
O-aarch64
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See llvm/llvm-project#55199 for the motivation.
In CAS we have already done this; in RMW and store we still use LDXP/STXP even if LSE is available because the performance benefits do not seem clear yet.