Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(es/minifier): Use FastId for DCE #9827

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Jan 1, 2025

Description:

I'll split this PR after finishing migration.

main:

image

Afte patching DCE:

image

After patching inlining part of Optimizer

image

Related issue:

@kdy1 kdy1 added this to the Planned milestone Jan 1, 2025
@kdy1 kdy1 self-assigned this Jan 1, 2025
Copy link

changeset-bot bot commented Jan 1, 2025

⚠️ No Changeset found

Latest commit: 165eaa7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kdy1 kdy1 changed the title perf(es/minifier): Use FastId for more places perf(es/minifier): Use FastId for DCE Jan 1, 2025
@kdy1 kdy1 force-pushed the rspack-fastid-2 branch 2 times, most recently from accf969 to 32da0d8 Compare January 1, 2025 02:25
Copy link

codspeed-hq bot commented Jan 1, 2025

CodSpeed Performance Report

Merging #9827 will degrade performances by 8.14%

Comparing kdy1:rspack-fastid-2 (165eaa7) with main (584a0a0)

Summary

⚡ 1 improvements
❌ 6 regressions
✅ 199 untouched benchmarks
🆕 1 new benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main kdy1:rspack-fastid-2 Change
common/allocator/alloc/no-scope/1000000 111.5 ms 116.1 ms -3.96%
es/lints/libs/moment 5.7 ms 5.4 ms +5.88%
es/lints/libs/react 1.6 ms 1.8 ms -8.14%
🆕 es/minifier/libs/rspack N/A 6.2 s N/A
es/visitor/base-perf/boxing_boxed 3.1 µs 3.3 µs -7.05%
es/visitor/base-perf/boxing_boxed_clone 2.3 µs 2.4 µs -5.97%
es/visitor/base-perf/boxing_unboxed 3.3 µs 3.5 µs -5.84%
es/visitor/base-perf/boxing_unboxed_clone 2.5 µs 2.6 µs -5.53%

@kdy1 kdy1 force-pushed the rspack-fastid-2 branch from 36991d5 to 165eaa7 Compare January 6, 2025 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant