fix: add ignoreDeprecations flag for TS 5.x
#8718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: bec04b5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Rich-Harris
reviewed
Jan 25, 2023
Rich-Harris
reviewed
Jan 25, 2023
| // @ts-ignore | ||
| let ts = undefined; | ||
| try { | ||
| ts = (await import('typescript')).default; |
There was a problem hiding this comment.
I think we might need to import relative to the cwd? We ran into this before with adapter-auto — it's possible, though rare, for typescript to be installed in a package while @sveltejs/kit is installed in a workspace root
There was a problem hiding this comment.
We're doing the same in write_types and I heard no complaints so far. Still do it?
There was a problem hiding this comment.
ah, yeah that's probably fine in that case. though we may as well DRY it out
Rich-Harris
approved these changes
Jan 26, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #8650
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.