Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support sveltekit apps on non-http protocols #13289

Closed
wants to merge 2 commits into from

Conversation

kran6a
Copy link

@kran6a kran6a commented Jan 8, 2025


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented Jan 8, 2025

🦋 Changeset detected

Latest commit: 878c2d3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kran6a kran6a marked this pull request as ready for review January 8, 2025 11:08
@kran6a
Copy link
Author

kran6a commented Jan 8, 2025

Navigation works only if you set absolute hrefs on your links. i.e: <a href="about:srcdoc#about">about</a> to access the /about route. Otherwise it performs a full page reload to the iframe host's URL with the #about hash appended.

This is enough for my use case but might be worth improving it so <a href="#about">about</a> works out of the box.

@eltigerchino
Copy link
Member

related #13231

@kran6a
Copy link
Author

kran6a commented Jan 9, 2025

#13231

Closing in favor of #13231
I would check for the protocol starting with http though to support more protocols where single-file webs/apps are common like ipfs (which already some browser resolve), file or proprietary protocols.

@kran6a kran6a closed this Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants