Use string literal type for CALL_HISTORY_METHOD #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the string literal `'@@router/CALL_HISTORY_METHOD'` as the type for `CALL_HISTORY_METHOD`.
I have a `type Action = LocationChangeAction | RouterAction` and would like to differentiate between types of actions using a switch statement like this:
```
switch (action.type) {
}
```
|
LGTM. Thanks for your contribution! |
Merged
|
@supasate could you publish it, please? |
|
Released in 5.0.0! (Beware of the breaking change. Please see the release note https://github.com/supasate/connected-react-router/releases/tag/v5.0.0) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the string literal
'@@router/CALL_HISTORY_METHOD'as the type forCALL_HISTORY_METHOD.I have a
type Action = LocationChangeAction | RouterActionand would like to differentiate between types of actions using a switch statement like this:The type needs to be a string literal rather than a generic string type for this to work.