createMatchSelector typedef string or object?

[MitchWeiss]

There isn't much documentation on createMatchSelector but in other places eg #38, the parameter is an object:

const matchSelector = createMatchSelector({ path: '/course/:id })

The typedef added in #235 expects a string.

I believe the typedef is incorrect. My understanding of the code is that this parameter is provided as the second parameter in react-router's matchPath which expects an object https://github.com/ReactTraining/react-router/blob/master/packages/react-router/docs/api/matchPath.md

Can anyone else confirm that this typedef is incorrect?

[robchristian]

Would also like to see some documentation surface. The readme leaves me thinking this library doesn't have support for route params.

[zaverden]

Current typedef does not cover all valid usecases.

connected-react-router/index.d.ts

Lines 73 to 75 in f275126

	export function createMatchSelector<
	S extends RouterRootState, Params extends { [K in keyof Params]?: string }
	>(path: string): matchSelectorFn<S, Params>;

The path argument is used a 2nd parameter for matchPah

connected-react-router/src/selectors.js

Line 34 in d2f0bb0

const match = matchPath(pathname, path)

In the matchPah 2nd argument is defined as string | string[] | RouteProps: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/3e0007a3a88eca10f61fcb55d78dd66e323f24c6/types/react-router/index.d.ts#L133