Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated global JSX namespace #4333

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Replace deprecated global JSX namespace #4333

merged 1 commit into from
Aug 29, 2024
+15 −15

Conversation

Janpot
Copy link
Contributor

@Janpot Janpot commented Jul 19, 2024

The global JSX namespace is deprecated. This Replaces it with React.JSX.

Motivation:
This will make the library compatible with [email protected] (Upcoming @types/react version). It comes at no backwards compatibility cost, the React.JSX namespace is already used in some places. At MUI we need @types/react@19 compatibility (but not necessarily react@19 compatibility) for mui/material-ui#42824.

@Janpot Janpot mentioned this pull request Jul 19, 2024
Closed
quantizor
quantizor approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@quantizor quantizor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@quantizor quantizor merged commit 8831f2e into styled-components:main Aug 29, 2024
5 checks passed
@Janpot Janpot deleted the fix-jsx-namespace branch August 29, 2024 05:29
@Janpot Janpot mentioned this pull request Sep 10, 2024
Merged
1 task
This was referenced Sep 20, 2024
Closed
Closed
@dilbarov dilbarov mentioned this pull request Sep 20, 2024
Open
@opensrc0 opensrc0 mentioned this pull request Sep 20, 2024
Open
@prathik2401 prathik2401 mentioned this pull request Sep 20, 2024
Merged
@MohammadGhajari MohammadGhajari mentioned this pull request Sep 20, 2024
Open
@Pavan20kumar Pavan20kumar mentioned this pull request Sep 20, 2024
Open
@leoo1992 leoo1992 mentioned this pull request Sep 20, 2024
Merged
@fantasticmrdavid fantasticmrdavid mentioned this pull request Sep 20, 2024
Closed
@Aziz-Mohamed Aziz-Mohamed mentioned this pull request Sep 20, 2024
Open
@fantasticmrdavid fantasticmrdavid mentioned this pull request Sep 20, 2024
Closed
@zntb zntb mentioned this pull request Sep 21, 2024
Merged
@MohammadGhajari MohammadGhajari mentioned this pull request Sep 21, 2024
Open
@ludolpr ludolpr mentioned this pull request Sep 21, 2024
Open
This was referenced Sep 22, 2024
Open
Open
This was referenced Sep 23, 2024
Open
Open
@X-oss-byte X-oss-byte mentioned this pull request Sep 23, 2024
Open
@nejidevelops nejidevelops mentioned this pull request Sep 23, 2024
Open
@opensrc0 opensrc0 mentioned this pull request Sep 23, 2024
Open
@MohammadGhajari MohammadGhajari mentioned this pull request Sep 24, 2024
Open
@navaneet-rao navaneet-rao mentioned this pull request Sep 25, 2024
Open
@nejidevelops nejidevelops mentioned this pull request Sep 25, 2024
Open
This was referenced Sep 26, 2024
Open
Open
@Kavindya-Udunuwara Kavindya-Udunuwara mentioned this pull request Sep 27, 2024
Open
@yungfossa yungfossa mentioned this pull request Sep 27, 2024
Open
This was referenced Sep 28, 2024
Open
Open
Open
Open
Open
@aarongarciah aarongarciah mentioned this pull request Oct 8, 2024
Open
@nejidevelops nejidevelops mentioned this pull request Oct 29, 2024
Open
@HaLaGu1L HaLaGu1L mentioned this pull request Nov 4, 2024
Open
@nejidevelops nejidevelops mentioned this pull request Nov 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quantizor quantizor quantizor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Janpot @quantizor