Fix compile error in test target when running on 32 bit device #978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Warning about implicit conversion that our compiler settings elevate to an error.
|
This test was recently added by me, in #954 |
|
While we're at it, I notice now that those color tests also don't compile on iOS 9. |
|
@joeydong-stripe I noticed that too. I figured it could be a separate PR, since it's a separate issue. |
joeydong-stripe
approved these changes
Jun 29, 2018
csabol-stripe
added a commit
that referenced
this pull request
Apr 26, 2022
* Adds bank name to icon code mapping * Set icon based on name * Adds new default icon and corner radius * Revert unneeded test changes * Update tests for default * Fix corner radius
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added a cast to
CGFloatMotivation
Warning about implicit conversion that our compiler settings elevate to an error.
Testing
Compiled/ran test suite on both iPhone 5 & iPhone 6