add detachSourceFromCustomer and updateCustomer to BackendAPIAdapter #813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bg-stripe
changed the title
bdorfman-stripe
suggested changes
Oct 16, 2017
| Instead of providing your own backend API adapter, you can now create an | ||
| `STPCustomerContext`, which will manage retrieving and updating a | ||
| Stripe customer for you. @see STPCustomerContext.h | ||
|
|
||
| */ | ||
| __attribute__((deprecated)) |
There was a problem hiding this comment.
Unmark this as deprecated?
| your own backend instead of using `STPCustomerContext`, you should make your | ||
| application's API client conform to this interface. It provides a "bridge" from | ||
| the prebuilt UI we expose (such as `STPPaymentMethodsViewController`) to your | ||
| backend to fetch the information it needs to power those views. | ||
|
|
||
| @deprecated Use `STPCustomerContext`. |
There was a problem hiding this comment.
Unmark as deprecated?
| // Cannot detach payment methods without customer context | ||
| return NO; | ||
| } | ||
|
|
||
| if (![self.apiAdapter respondsToSelector:@selector(detachSourceFromCustomer:completion:)]) { | ||
| // Cannot detach payment methods if customerContext is an apiAdapter | ||
| // that doesn't implement detachSource |
There was a problem hiding this comment.
Should this return NO?
There was a problem hiding this comment.
oh derp, good catch
| #pragma clang diagnostic push | ||
| #pragma clang diagnostic ignored "-Wdeprecated" | ||
| @property (nonatomic, strong, nullable, readwrite) id<STPBackendAPIAdapter> apiAdapter; | ||
| #pragma clang diagnostic pop |
There was a problem hiding this comment.
Should unmark as deprecated and remove these pragmas
|
@bdorfman-stripe re-r? I've undeprecated and updated docs in a7e31aa The documentation updates are a bit noisy - mostly fixing line breaks. I made some actual content changes in the STPBackendAPIAdapter docs. |
mludowise-stripe
added a commit
that referenced
this pull request
Mar 2, 2022
… of frame count (#813) This change removes the frame minimum from the MotionBlurDetector in place of a time minimum for consecutive frames. This is more consistent because different devices have different frame rates, depending on their CPU or whether they contain a neural engine. Previous to this change, we were still seeing some motion blur in images on faster performing devices. The current default is 500ms, however this will eventually be server driven.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @bdorfman-stripe
Requested in #812 .
I decided to add these methods to
STPBackendAPIAdapter, to keepSTPCustomerContext.hclean (most users shouldn't need to know these exist). It also lets users that want to stick withSTPBackendAPIAdapterto add deletion and shipping update functionality.