Disable code coverage for carthage xcode 9 compatibility #795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't disable for the rest of the project or tests.
This reverts commit 9d8e0da.
|
👍 |
joeydong-stripe
approved these changes
Sep 13, 2017
mludowise-stripe
added a commit
that referenced
this pull request
Mar 2, 2022
Previously, the document scanner snaps an image of the ID document too quickly, often including motion blur. This change adds a `MotionBlurDetector` that tracks how much the ID document has moved from frame to frame in the camera feed using the IOU (intersection over union) algorithm. The threshold for how much the document can move between frames and how many frames it must remain still is configurable via `DocumentScanner.Configuration`. Currently, this is hardcoded, but this will eventually be configured from the API response.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Xcode 9 now includes code coverage for all except Archive command, instead of just Test command, which breaks Carthage[0]. They apparently don't want to work around this on their end, so all framework developers have to change their project settings -_-
Fixes #794
[0] Carthage/Carthage#2056