Fixes missing custom placeholder text #1576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuki-stripe
approved these changes
May 15, 2020
kgaidis-stripe
added a commit
that referenced
this pull request
Dec 2, 2022
Financial Connections: fixed an issue where sometimes Partner Auth step would cause unnecessary transition jitters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changed compressedCardNumber to take a placeholder argument so that it doesn't always fall back to the default placeholder. The fallback to the default placeholder was causing custom placeholders to disappear when compressed.
Motivation
#1575
Testing
Tested with submitted issue configuration. Added automated test