-
Notifications
You must be signed in to change notification settings - Fork 999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update postal code logic #1479
Merged
Merged
Update postal code logic #1479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidme-stripe
requested review from
yuki-stripe,
csabol-stripe and
mshafrir-stripe
January 23, 2020 23:51
davidme-stripe
changed the title
WIP: Update postal code logic
Update postal code logic
Jan 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yay UI tests!
Looks good with a couple questions inline
We should probably add some text to MIGRATING.md describing how the default behavior has changed and why you probably don't want to revert the change but here's how you would if you really want to
csabol-stripe
approved these changes
Feb 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
STPBillingAddressFieldsZip
is selected,STPAddCardViewController
will now embed the postal code collection into theSTPPaymentCardTextField
instead of splitting it out into a separate row.Motivation
We're now recommending that all users in the US collect postal codes.
Testing
STPBillingAddressFields
settings.