Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround iOS 13 TableViewRowData issue #1427

Merged
merged 1 commit into from
Oct 25, 2019

Conversation

davidme-stripe
Copy link
Contributor

@davidme-stripe davidme-stripe commented Oct 25, 2019

Summary

When we request numberOfRowsInSection from a UITableView while the UITableView's ViewController is being initialized, the internal UITableViewRowData is sometimes not in a good state and doesn't yet know how many sections we have. Work around this by requesting numberOfRowsInSection: from our controller instead of the tableView.

Motivation

Fixes #1426.

Testing

I can't reproduce the issue locally, but @odedharth says this fixed it.

@davidme-stripe davidme-stripe merged commit 2858b69 into master Oct 25, 2019
@davidme-stripe davidme-stripe deleted the davidme/fix-ios13-tableviewdata branch October 25, 2019 22:46
@shamilovtim
Copy link

Hello @davidme-stripe could we have this cherrypicked onto a 14.0.3 release? We're currently stuck with no viable upgrade path due to a monolithic implementation that will take a long time to fix, 14.x is the last version that works for token users and this is a common bug in production.

ccen-stripe pushed a commit that referenced this pull request Sep 19, 2022
* [Link] Add consent_action param to Link signups

* Cleanup dead init argument
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash when adding a card
4 participants