Workaround iOS 13 TableViewRowData issue #1427
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When we request numberOfRowsInSection from a UITableView while the UITableView's ViewController is being initialized, the internal UITableViewRowData is sometimes not in a good state and doesn't yet know how many sections we have. Work around this by requesting numberOfRowsInSection: from our controller instead of the tableView.
Motivation
Fixes #1426.
Testing
I can't reproduce the issue locally, but @odedharth says this fixed it.