Enable UINavigationBar translucency by default #1367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuki-stripe
approved these changes
Sep 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Enable translucency by default to fix a few
prefersLargeTitles-related bugs.Motivation
It doesn't feel like UIViewController's Large Title support was designed with
translucency = NOin mind. It expects the UIViewController's view to draw underneath the area of the UINavigationBar, which doesn't happen when translucency is disabled. I considered enablingextendedLayoutIncludesOpaqueBarsinstead, which would only enable the overdrawing behavior, but no longer opting out of translucency seems like it would bring us closer to the UIKit happy path.Testing
Tested in simulator on iOS 12.2 and iOS 13 in Standard Integration and UI Examples with
prefersLargeTitles = YES.