ApplePay support in STPPaymentHandler, STPPaymentContext #1264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…enticationWillPresent to dismiss apple pay, handle the dismissal case not calling paymentAuthorizationViewControllerDidFinish:
…n STPPaymentContext
csabol-stripe
approved these changes
Jul 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
STPPaymentHandler can't present on top of the Apple Pay sheet. This PR adds a
authenticationWillPresent:delegate method toSTPAuthenticationContextto let the user dismiss the Apple Pay sheet.I also reworked users of
STPPaymentHandlerto handle this:STPPaymentContextnow conforms toSTPAuthenticationContext, and users should pass it toSTPPaymentHandlerSTPPaymentHandlerMotivation
Make Apple Pay work with STPPaymentHandler
Testing
Manually tested the following combinations:
STPPaymentContext, Custom Integration
x
Apple Pay, manual card entry
x
Test cards 3220, 3063, 4242 (3DS2, 3DS1, regular)