Add custom asset to Add Card VC for entering Amex CVC #1046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is waiting on new assets. |
The cvc is found on the front of the card, not the back, so a flip animation doesn't make sense for Amex cards.
|
Updated assets, and used cross-dissolve instead of flip for Amex: |
csabol-stripe
approved these changes
Dec 4, 2018
yuki-stripe
pushed a commit
that referenced
this pull request
May 3, 2022
Migrated SaveCheckboxElement to StripeUICore and renamed to CheckboxElement so it can be shared with StripeIdentity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The payment text field has different assets for CVC, based on whether the card is an amex or not. Adding the same distinction to the card icon on
STPAddCardViewControllerMotivation
IOS-83
Testing
Manually tested in the example app.