-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Update usePermission types for TS 4.4.2 compatibility #2101
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @scvnathan! I wonder if we can change typescript
version in package.json
→ devDependencies
to 4.4.2
in this PR too. This will make sure that linting fails if the typings are still incompatible with the latest version. I hope that the build won’t become incompatible with older typescript versions, but I’m not 100% sure 🤔
@streamich WDYT?
Last I checked, there were a lot of other compatibility issues related to upgrading TS. I think its probably best to get this out the door to fix builds and then work on broader compatibility fixes in a different PR |
Thanks for your contribution @scvnathan! The diff makes sense 💯 Let’s wait for @streamich to take a quick look and merge, I hope we can try out a new release soon 🙂 |
@kachkaev Sorry to bother - but do you know if there's manual fix for this that I can temporarily apply, while we are waiting for a merge and release? UPDATE: I enabled skipLibCheck in TS config to bypass it. |
@fnick851 I’ve found some temp workaround in our project, but I can’t bring it up because I don’t have access to that codebase ATM. Perhaps @obfusticatedcode / @jquintozamora could share some details (from a PR diff)? |
@streamich is there any hope to merge this and push a new release? |
Workaround if not using |
Description
fixes #2092, #2056
If you want to test this out locally be sure to change the Typescript version to
4.4.2
inpackage.json
Type of change
Checklist
yarn test
)yarn lint
). Fix it withyarn lint:fix
in case of failure.yarn lint:types
).