fix(useMeasure): let ref accept null value #1267
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axelboc
commented
Jun 4, 2020
| }); | ||
|
|
||
| expect(observe).not.toHaveBeenCalled(); | ||
| }) |
There was a problem hiding this comment.
New test to make sure ref accepts null and that useMeasure doesn't try to observe a null element.
|
@streamich Hi can we get this merged? |
axelboc
commented
Mar 24, 2021
|
|
||
| it('by default, state defaults every value to -1', () => { | ||
| it('by default, state defaults every value to 0', () => { |
There was a problem hiding this comment.
Left over from an old revert of the hooks' behaviour.
axelboc
commented
Mar 24, 2021
| const { result } = renderHook(() => useMeasure()); | ||
|
|
||
| act(() => { | ||
| const div = document.createElement('div'); | ||
| (result.current[0] as UseMeasureRef)(div); | ||
| result.current[0](div); |
There was a problem hiding this comment.
Type is properly inferred by TS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #1264
Strangely, the Storybook story wasn't showing the error. I'm not sure why 🤷♂️
Type of change
Checklist
Add documentationAdd hook's story at Storybookyarn test)yarn lint). Fix it withyarn lint:fixin case of failure.yarn lint:types).