Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[move] Update move dep #3367

Merged
merged 1 commit into from
Apr 27, 2022
Merged

[move] Update move dep #3367

merged 1 commit into from
Apr 27, 2022

Conversation

jolestar
Copy link
Member

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

  1. Upgrade Move repo to https://github.com/move-language/move
  2. Pickup Fix the bug that move-disassembler panicked for using wrong type_param_context when handling generic types (#49)
  3. Pickup [repo] Remove workspace hack. (#55)

Diff view:

https://github.com/starcoinorg/move/compare/0b4655469084eb2fb6b8a6a7690342d767f05e5b..2e8f03e7bb24e49dbe807bcfc0c32c4f605bba71

Other information

@jolestar jolestar requested review from nanne007, xudon9 and LemonHX April 25, 2022 04:24
@codecov
Copy link

codecov bot commented Apr 26, 2022

Codecov Report

Merging #3367 (476de13) into master (8616e39) will decrease coverage by 0.45%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3367      +/-   ##
==========================================
- Coverage   32.36%   31.92%   -0.44%     
==========================================
  Files         500      500              
  Lines       46815    46815              
  Branches    21315    21305      -10     
==========================================
- Hits        15147    14941     -206     
- Misses      17564    17585      +21     
- Partials    14104    14289     +185     
Flag Coverage Δ
unittests 31.92% <ø> (-0.44%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
executor/src/block_executor.rs 22.23% <0.00%> (-20.00%) ⬇️
chain/open-block/src/lib.rs 31.79% <0.00%> (-13.90%) ⬇️
commons/accumulator/src/tree.rs 54.68% <0.00%> (-12.80%) ⬇️
chain/src/verifier/mod.rs 36.72% <0.00%> (-11.71%) ⬇️
vm/types/src/on_chain_config/mod.rs 43.84% <0.00%> (-10.95%) ⬇️
vm/natives/src/token.rs 26.67% <0.00%> (-6.66%) ⬇️
chain/src/chain.rs 33.82% <0.00%> (-6.31%) ⬇️
state/state-store-api/src/lib.rs 43.75% <0.00%> (-6.25%) ⬇️
commons/forkable-jellyfish-merkle/src/lib.rs 40.62% <0.00%> (-4.98%) ⬇️
vm/vm-runtime/src/starcoin_vm.rs 36.63% <0.00%> (-4.68%) ⬇️
... and 59 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9482634...476de13. Read the comment docs.

@github-actions
Copy link

Benchmark for e1a40f0

Click to view benchmark
Test Base PR %
accumulator_append 584.9±12.88µs 587.1±8.69µs +0.38%
block_apply/block_apply_10 263.7±0.66ms 264.0±0.98ms +0.11%
block_apply/block_apply_1000 27.0±0.03s 27.3±0.02s +1.11%
get_with_proof/db_store 36.4±0.58µs 36.9±0.26µs +1.37%
get_with_proof/mem_store 31.6±0.38µs 31.8±0.46µs +0.63%
put_and_commit/db_store/1 97.3±7.43µs 97.2±5.10µs -0.10%
put_and_commit/db_store/10 861.6±39.17µs 873.8±45.90µs +1.42%
put_and_commit/db_store/100 7.4±0.33ms 7.5±0.32ms +1.35%
put_and_commit/db_store/5 443.9±34.85µs 444.8±23.13µs +0.20%
put_and_commit/db_store/50 3.8±0.16ms 3.9±0.19ms +2.63%
put_and_commit/mem_store/1 62.6±5.64µs 62.9±5.66µs +0.48%
put_and_commit/mem_store/10 584.7±48.91µs 585.4±47.33µs +0.12%
put_and_commit/mem_store/100 5.7±0.81ms 5.7±0.82ms 0.00%
put_and_commit/mem_store/5 295.0±25.45µs 297.0±24.89µs +0.68%
put_and_commit/mem_store/50 2.9±0.19ms 2.9±0.19ms 0.00%
query_block/query_block_in(10)_times(100) 3.9±0.12ms 3.8±0.12ms -2.56%
query_block/query_block_in(10)_times(1000) 38.4±0.86ms 38.6±1.04ms +0.52%
query_block/query_block_in(10)_times(10000) 387.0±7.18ms 387.6±5.40ms +0.16%
query_block/query_block_in(1000)_times(100) 957.2±6.71µs 936.4±4.21µs -2.17%
query_block/query_block_in(1000)_times(1000) 9.5±0.08ms 9.4±0.09ms -1.05%
query_block/query_block_in(1000)_times(10000) 95.2±0.57ms 94.3±0.73ms -0.95%
storage_transaction 1080.4±345.75µs 1049.2±286.01µs -2.89%
vm/transaction_execution/1 311.6±0.60ms 316.4±0.78ms +1.54%
vm/transaction_execution/10 98.4±0.19ms 99.5±0.16ms +1.12%
vm/transaction_execution/20 91.5±0.15ms 92.9±0.44ms +1.53%
vm/transaction_execution/5 120.4±0.45ms 121.8±0.39ms +1.16%
vm/transaction_execution/50 106.4±0.97ms 107.2±0.33ms +0.75%

@nanne007 nanne007 merged commit b9ede0c into master Apr 27, 2022
@nanne007 nanne007 deleted the update_move_deps branch April 27, 2022 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants