Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync block cron #3354

Merged
merged 4 commits into from
Apr 20, 2022
Merged

sync block cron #3354

merged 4 commits into from
Apr 20, 2022

Conversation

yourmoonlight
Copy link
Collaborator

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Add github cron workflow for sync blocks

@codecov
Copy link

codecov bot commented Apr 19, 2022

Codecov Report

Merging #3354 (6d2cd35) into master (8a741cb) will decrease coverage by 0.28%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3354      +/-   ##
==========================================
- Coverage   32.11%   31.83%   -0.27%     
==========================================
  Files         500      500              
  Lines       46814    46814              
  Branches    21311    21311              
==========================================
- Hits        15028    14898     -130     
+ Misses      17737    17675      -62     
- Partials    14049    14241     +192     
Flag Coverage Δ
unittests 31.83% <ø> (-0.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...m/types/src/account_config/events/config_change.rs 66.67% <0.00%> (-33.33%) ⬇️
vm/natives/src/account.rs 12.50% <0.00%> (-18.75%) ⬇️
rpc/server/src/module/mod.rs 0.00% <0.00%> (-16.66%) ⬇️
vm/types/src/on_chain_config/mod.rs 41.10% <0.00%> (-15.06%) ⬇️
vm/types/src/transaction/error.rs 3.58% <0.00%> (-10.71%) ⬇️
vm/natives/src/lib.rs 80.00% <0.00%> (-10.00%) ⬇️
chain/open-block/src/lib.rs 31.79% <0.00%> (-7.28%) ⬇️
executor/src/block_executor.rs 22.23% <0.00%> (-6.66%) ⬇️
...mons/forkable-jellyfish-merkle/src/iterator/mod.rs 42.50% <0.00%> (-6.00%) ⬇️
cmd/starcoin/src/cli_state.rs 48.79% <0.00%> (-4.87%) ⬇️
... and 79 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a741cb...6d2cd35. Read the comment docs.

@github-actions
Copy link

Benchmark for 72feb2f

Click to view benchmark
Test Base PR %
accumulator_append 584.9±15.96µs 585.0±11.23µs +0.02%
block_apply/block_apply_10 262.7±0.30ms 262.6±0.79ms -0.04%
block_apply/block_apply_1000 27.1±0.04s 26.8±0.02s -1.11%
get_with_proof/db_store 36.0±0.37µs 36.3±0.31µs +0.83%
get_with_proof/mem_store 31.2±0.57µs 31.3±0.38µs +0.32%
put_and_commit/db_store/1 96.2±5.05µs 96.6±5.03µs +0.42%
put_and_commit/db_store/10 868.2±43.78µs 857.5±41.19µs -1.23%
put_and_commit/db_store/100 7.5±0.37ms 7.4±0.31ms -1.33%
put_and_commit/db_store/5 438.7±23.71µs 441.2±21.70µs +0.57%
put_and_commit/db_store/50 3.8±0.18ms 3.9±0.22ms +2.63%
put_and_commit/mem_store/1 61.7±5.76µs 61.9±5.93µs +0.32%
put_and_commit/mem_store/10 579.7±50.64µs 573.8±50.61µs -1.02%
put_and_commit/mem_store/100 5.7±0.84ms 5.7±0.85ms 0.00%
put_and_commit/mem_store/5 292.8±26.57µs 290.8±26.34µs -0.68%
put_and_commit/mem_store/50 2.8±0.19ms 2.8±0.19ms 0.00%
query_block/query_block_in(10)_times(100) 3.8±0.08ms 3.8±0.14ms 0.00%
query_block/query_block_in(10)_times(1000) 38.3±0.85ms 38.1±1.21ms -0.52%
query_block/query_block_in(10)_times(10000) 384.2±6.10ms 382.5±6.90ms -0.44%
query_block/query_block_in(1000)_times(100) 950.6±10.54µs 940.8±12.41µs -1.03%
query_block/query_block_in(1000)_times(1000) 9.5±0.05ms 9.4±0.08ms -1.05%
query_block/query_block_in(1000)_times(10000) 95.5±0.91ms 94.4±1.02ms -1.15%
storage_transaction 1060.6±284.95µs 1078.1±308.30µs +1.65%
vm/transaction_execution/1 310.1±2.26ms 310.4±2.40ms +0.10%
vm/transaction_execution/10 98.8±1.46ms 98.2±1.17ms -0.61%
vm/transaction_execution/20 91.3±0.68ms 91.3±0.46ms 0.00%
vm/transaction_execution/5 119.2±1.07ms 119.1±0.35ms -0.08%
vm/transaction_execution/50 105.4±0.51ms 106.5±2.97ms +1.04%

@github-actions
Copy link

Benchmark for f42e3f2

Click to view benchmark
Test Base PR %
accumulator_append 580.8±16.31µs 578.8±12.84µs -0.34%
block_apply/block_apply_10 260.7±1.01ms 264.4±2.57ms +1.42%
block_apply/block_apply_1000 26.6±0.03s 26.9±0.03s +1.13%
get_with_proof/db_store 36.7±0.41µs 35.7±0.33µs -2.72%
get_with_proof/mem_store 31.3±0.24µs 31.0±0.22µs -0.96%
put_and_commit/db_store/1 95.1±4.62µs 94.9±4.70µs -0.21%
put_and_commit/db_store/10 852.6±40.45µs 842.5±38.48µs -1.18%
put_and_commit/db_store/100 7.3±0.31ms 7.3±0.46ms 0.00%
put_and_commit/db_store/5 435.2±21.61µs 432.7±21.52µs -0.57%
put_and_commit/db_store/50 3.8±0.17ms 3.8±0.19ms 0.00%
put_and_commit/mem_store/1 61.9±5.58µs 61.0±5.52µs -1.45%
put_and_commit/mem_store/10 580.2±46.16µs 573.1±47.82µs -1.22%
put_and_commit/mem_store/100 5.7±0.83ms 5.6±0.81ms -1.75%
put_and_commit/mem_store/5 294.1±24.03µs 286.5±24.20µs -2.58%
put_and_commit/mem_store/50 2.8±0.18ms 2.8±0.18ms 0.00%
query_block/query_block_in(10)_times(100) 3.8±0.08ms 3.9±0.07ms +2.63%
query_block/query_block_in(10)_times(1000) 38.2±1.02ms 38.3±0.51ms +0.26%
query_block/query_block_in(10)_times(10000) 386.5±7.53ms 380.7±4.14ms -1.50%
query_block/query_block_in(1000)_times(100) 932.1±10.46µs 938.2±7.51µs +0.65%
query_block/query_block_in(1000)_times(1000) 9.4±0.08ms 9.3±0.07ms -1.06%
query_block/query_block_in(1000)_times(10000) 93.6±0.68ms 93.2±0.50ms -0.43%
storage_transaction 1058.5±283.38µs 1054.4±286.52µs -0.39%
vm/transaction_execution/1 312.5±0.97ms 309.0±0.77ms -1.12%
vm/transaction_execution/10 98.4±0.41ms 97.8±0.85ms -0.61%
vm/transaction_execution/20 91.9±1.08ms 91.1±0.24ms -0.87%
vm/transaction_execution/5 120.2±0.47ms 119.0±0.45ms -1.00%
vm/transaction_execution/50 106.3±1.05ms 105.3±0.72ms -0.94%

@yourmoonlight yourmoonlight marked this pull request as ready for review April 20, 2022 03:51
Copy link
Member

@jolestar jolestar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jolestar jolestar merged commit a3cecd8 into master Apr 20, 2022
@jolestar jolestar deleted the feat/ci_sync_block branch April 20, 2022 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants