Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mpm] Fix #3325 #3347

Merged
merged 1 commit into from
Apr 16, 2022
Merged

[mpm] Fix #3325 #3347

merged 1 commit into from
Apr 16, 2022

Conversation

jolestar
Copy link
Member

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: Fix #3325

What is the new behavior?

Other information

@jolestar jolestar requested review from nanne007 and LemonHX April 15, 2022 23:28
@codecov
Copy link

codecov bot commented Apr 15, 2022

Codecov Report

Merging #3347 (8e8a213) into master (6251853) will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3347      +/-   ##
==========================================
+ Coverage   31.96%   32.04%   +0.09%     
==========================================
  Files         500      500              
  Lines       46810    46810              
  Branches    21305    21305              
==========================================
+ Hits        14959    14997      +38     
+ Misses      17614    17474     -140     
- Partials    14237    14339     +102     
Flag Coverage Δ
unittests 32.04% <ø> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
vm/natives/src/vector.rs 16.67% <0.00%> (-8.33%) ⬇️
config/src/helper.rs 45.10% <0.00%> (-7.84%) ⬇️
vm/natives/src/account.rs 25.00% <0.00%> (-6.25%) ⬇️
config/src/lib.rs 33.00% <0.00%> (-2.38%) ⬇️
vm/natives/src/token.rs 26.67% <0.00%> (-2.22%) ⬇️
vm/vm-runtime/src/starcoin_vm.rs 38.15% <0.00%> (-2.15%) ⬇️
commons/timeout-join-handler/src/lib.rs 40.43% <0.00%> (-2.12%) ⬇️
state/statedb/src/lib.rs 39.25% <0.00%> (-2.03%) ⬇️
commons/accumulator/src/tree.rs 52.71% <0.00%> (-1.97%) ⬇️
config/src/metrics_config.rs 53.93% <0.00%> (-1.96%) ⬇️
... and 61 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6251853...8e8a213. Read the comment docs.

@jolestar jolestar merged commit 0033d9a into master Apr 16, 2022
@jolestar jolestar deleted the fix/mpm-panic branch April 16, 2022 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

move-package-manager panicked in check-compatibility command
2 participants