Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARC had been upgraded, it is ok to add integration test back #3303

Merged
merged 6 commits into from
Apr 6, 2022

Conversation

yourmoonlight
Copy link
Collaborator

ARC had been upgraded, it is ok to add integration test back

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe)

@codecov
Copy link

codecov bot commented Mar 25, 2022

Codecov Report

Merging #3303 (a368767) into master (f759246) will increase coverage by 0.23%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3303      +/-   ##
==========================================
+ Coverage   32.25%   32.47%   +0.23%     
==========================================
  Files         500      500              
  Lines       46769    46769              
  Branches    21263    21262       -1     
==========================================
+ Hits        15079    15182     +103     
- Misses      17662    17799     +137     
+ Partials    14028    13788     -240     
Flag Coverage Δ
unittests 32.47% <ø> (+0.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...m/types/src/account_config/events/config_change.rs 66.67% <0.00%> (-33.33%) ⬇️
vm/types/src/language_storage_ext.rs 37.50% <0.00%> (-12.50%) ⬇️
vm/types/src/on_chain_config/vm_config.rs 35.00% <0.00%> (-11.66%) ⬇️
...ccount_config/resources/module_upgrade_strategy.rs 34.29% <0.00%> (-8.57%) ⬇️
abi/decoder/src/lib.rs 1.58% <0.00%> (-7.87%) ⬇️
...mons/forkable-jellyfish-merkle/src/iterator/mod.rs 38.50% <0.00%> (-6.50%) ⬇️
rpc/api/src/contract_api.rs 11.77% <0.00%> (-5.88%) ⬇️
vm/resource-viewer/src/lib.rs 0.66% <0.00%> (-5.26%) ⬇️
state/state-tree/src/mock/mod.rs 43.48% <0.00%> (-4.34%) ⬇️
rpc/server/src/module/contract_rpc.rs 3.71% <0.00%> (-3.70%) ⬇️
... and 80 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f759246...a368767. Read the comment docs.

@jolestar jolestar requested review from sanlee42 and jolestar March 31, 2022 02:45
@jolestar
Copy link
Member

@yourmoonlight 奇怪,怎么好像还是会卡住

@yourmoonlight
Copy link
Collaborator Author

@yourmoonlight 奇怪,怎么好像还是会卡住

我看下

@github-actions
Copy link

github-actions bot commented Apr 5, 2022

Benchmark for 44853a1

Click to view benchmark
Test Base PR %
accumulator_append 593.4±14.32µs 593.6±12.42µs +0.03%
block_apply/block_apply_10 267.5±0.35ms 266.9±1.83ms -0.22%
block_apply/block_apply_1000 27.4±0.02s 27.5±0.02s +0.36%
get_with_proof/db_store 36.6±0.44µs 36.2±0.34µs -1.09%
get_with_proof/mem_store 31.2±0.29µs 31.2±0.30µs 0.00%
put_and_commit/db_store/1 96.3±4.99µs 95.5±5.26µs -0.83%
put_and_commit/db_store/10 861.0±41.54µs 861.7±41.31µs +0.08%
put_and_commit/db_store/100 7.4±0.31ms 7.4±0.31ms 0.00%
put_and_commit/db_store/5 440.7±20.32µs 442.1±23.74µs +0.32%
put_and_commit/db_store/50 3.8±0.17ms 3.8±0.18ms 0.00%
put_and_commit/mem_store/1 61.6±5.72µs 61.2±5.66µs -0.65%
put_and_commit/mem_store/10 574.6±49.50µs 569.5±48.36µs -0.89%
put_and_commit/mem_store/100 5.7±0.82ms 5.6±0.84ms -1.75%
put_and_commit/mem_store/5 290.8±25.62µs 288.8±25.87µs -0.69%
put_and_commit/mem_store/50 2.8±0.20ms 2.8±0.19ms 0.00%
query_block/query_block_in(10)_times(100) 3.9±0.09ms 3.9±0.09ms 0.00%
query_block/query_block_in(10)_times(1000) 38.5±1.54ms 38.5±0.70ms 0.00%
query_block/query_block_in(10)_times(10000) 385.4±8.02ms 384.0±6.55ms -0.36%
query_block/query_block_in(1000)_times(100) 981.1±9.09µs 954.7±18.21µs -2.69%
query_block/query_block_in(1000)_times(1000) 9.9±0.06ms 9.7±0.22ms -2.02%
query_block/query_block_in(1000)_times(10000) 98.6±1.26ms 95.3±0.64ms -3.35%
storage_transaction 1080.8±311.19µs 1072.3±286.54µs -0.79%
vm/transaction_execution/1 315.5±0.47ms 316.7±4.05ms +0.38%
vm/transaction_execution/10 98.9±0.40ms 99.1±1.40ms +0.20%
vm/transaction_execution/20 91.3±0.72ms 91.0±0.68ms -0.33%
vm/transaction_execution/5 121.1±0.69ms 120.8±0.33ms -0.25%
vm/transaction_execution/50 102.7±0.67ms 103.9±1.60ms +1.17%

@jolestar jolestar mentioned this pull request Apr 6, 2022
7 tasks
@jolestar
Copy link
Member

jolestar commented Apr 6, 2022

bors merge

@bors
Copy link

bors bot commented Apr 6, 2022

Configuration problem:
bors.toml: not found

@jolestar jolestar merged commit 4a9baa4 into master Apr 6, 2022
@jolestar jolestar deleted the feature/add_integration_test branch April 6, 2022 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants