Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update schemars #3268

Merged
merged 2 commits into from
Mar 8, 2022
Merged

Update schemars #3268

merged 2 commits into from
Mar 8, 2022

Conversation

sanlee42
Copy link
Member

@sanlee42 sanlee42 commented Mar 7, 2022

Remove the move crates in schemars

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

remove the move crates in schemars
@codecov
Copy link

codecov bot commented Mar 7, 2022

Codecov Report

Merging #3268 (ee070c5) into master (ce27ccd) will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3268      +/-   ##
==========================================
+ Coverage   31.92%   32.00%   +0.09%     
==========================================
  Files         499      499              
  Lines       46240    46194      -46     
  Branches    21206    20898     -308     
==========================================
+ Hits        14756    14780      +24     
- Misses      17417    17627     +210     
+ Partials    14067    13787     -280     
Flag Coverage Δ
unittests 32.00% <ø> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
test-helper/src/dummy_network_service.rs 22.23% <0.00%> (-14.81%) ⬇️
vm/types/src/transaction_metadata.rs 56.72% <0.00%> (-8.95%) ⬇️
state/state-store-api/src/lib.rs 43.75% <0.00%> (-6.25%) ⬇️
vm/natives/src/token.rs 28.89% <0.00%> (-4.44%) ⬇️
types/src/startup_info.rs 65.14% <0.00%> (-3.66%) ⬇️
commons/accumulator/src/tree_store/mock.rs 35.14% <0.00%> (-2.70%) ⬇️
network-p2p/src/peer_info.rs 44.05% <0.00%> (-2.59%) ⬇️
...ns/forkable-jellyfish-merkle/src/tree_cache/mod.rs 71.43% <0.00%> (-2.38%) ⬇️
commons/accumulator/src/tree.rs 51.71% <0.00%> (-1.95%) ⬇️
commons/forkable-jellyfish-merkle/src/lib.rs 41.00% <0.00%> (-1.53%) ⬇️
... and 88 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce27ccd...ee070c5. Read the comment docs.

@sanlee42 sanlee42 requested a review from jolestar March 7, 2022 06:23
@github-actions
Copy link

github-actions bot commented Mar 7, 2022

Benchmark for eec20e3

Click to view benchmark
Test Base PR %
accumulator_append 599.1±10.68µs 595.8±16.89µs -0.55%
block_apply/block_apply_10 267.8±1.26ms 267.1±0.74ms -0.26%
block_apply/block_apply_1000 27.3±0.02s 27.3±0.10s 0.00%
get_with_proof/db_store 36.0±0.48µs 36.7±0.43µs +1.94%
get_with_proof/mem_store 31.5±0.49µs 31.5±0.40µs 0.00%
put_and_commit/db_store/1 95.3±5.08µs 95.3±4.79µs 0.00%
put_and_commit/db_store/10 850.5±38.37µs 854.0±40.01µs +0.41%
put_and_commit/db_store/100 7.3±0.30ms 7.4±0.31ms +1.37%
put_and_commit/db_store/5 432.5±21.65µs 417.8±20.74µs -3.40%
put_and_commit/db_store/50 3.8±0.17ms 3.8±0.18ms 0.00%
put_and_commit/mem_store/1 61.0±5.28µs 62.3±5.41µs +2.13%
put_and_commit/mem_store/10 571.8±44.26µs 583.3±48.28µs +2.01%
put_and_commit/mem_store/100 5.6±0.33ms 5.7±0.79ms +1.79%
put_and_commit/mem_store/5 288.8±24.15µs 296.2±24.45µs +2.56%
put_and_commit/mem_store/50 2.8±0.09ms 2.9±0.18ms +3.57%
query_block/query_block_in(10)_times(100) 3.9±0.16ms 3.9±0.12ms 0.00%
query_block/query_block_in(10)_times(1000) 39.0±0.89ms 39.2±1.51ms +0.51%
query_block/query_block_in(10)_times(10000) 386.9±8.72ms 381.9±6.37ms -1.29%
query_block/query_block_in(1000)_times(100) 957.2±10.44µs 947.0±8.72µs -1.07%
query_block/query_block_in(1000)_times(1000) 9.6±0.14ms 9.4±0.08ms -2.08%
query_block/query_block_in(1000)_times(10000) 96.6±1.50ms 94.4±1.01ms -2.28%
storage_transaction 1052.1±287.41µs 1057.6±287.02µs +0.52%
vm/transaction_execution/1 315.2±1.00ms 314.4±0.81ms -0.25%
vm/transaction_execution/10 98.7±0.20ms 99.1±1.56ms +0.41%
vm/transaction_execution/20 91.2±0.93ms 91.3±0.55ms +0.11%
vm/transaction_execution/5 121.3±0.37ms 120.7±0.77ms -0.49%
vm/transaction_execution/50 102.9±0.47ms 103.4±0.93ms +0.49%

@sanlee42 sanlee42 merged commit 6dac036 into master Mar 8, 2022
@sanlee42 sanlee42 deleted the schemars branch March 8, 2022 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants