Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cmd] dev package auto convert module to Move file format version 3. #3237

Merged
merged 1 commit into from
Feb 23, 2022

Conversation

jolestar
Copy link
Member

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

the dev package command should serialize the Move module with version 3 file format.

Other information

This commit has cherry-picked to branch release-v1.10, and release a new version: https://github.com/starcoinorg/starcoin/releases/tag/v1.10.1

@jolestar jolestar requested a review from nanne007 February 22, 2022 16:17
@codecov
Copy link

codecov bot commented Feb 22, 2022

Codecov Report

Merging #3237 (59e1939) into master (15fc4fa) will increase coverage by 0.54%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3237      +/-   ##
==========================================
+ Coverage   31.97%   32.51%   +0.54%     
==========================================
  Files         503      503              
  Lines       46375    46375              
  Branches    21286    21286              
==========================================
+ Hits        14826    15072     +246     
+ Misses      17460    17323     -137     
+ Partials    14089    13980     -109     
Flag Coverage Δ
unittests 32.51% <0.00%> (+0.54%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
vm/compiler/src/bytecode_transpose.rs 0.00% <0.00%> (ø)
rpc/server/src/module/mod.rs 0.00% <0.00%> (-16.66%) ⬇️
vm/types/src/transaction/error.rs 3.58% <0.00%> (-10.71%) ⬇️
vm/natives/src/account.rs 25.00% <0.00%> (-6.25%) ⬇️
cmd/starcoin/src/cli_state.rs 44.74% <0.00%> (-5.26%) ⬇️
commons/crypto/src/multi_ed25519/multi_shard.rs 42.86% <0.00%> (-4.23%) ⬇️
commons/service-registry/src/service_actor.rs 38.71% <0.00%> (-3.22%) ⬇️
network/api/src/tests.rs 22.06% <0.00%> (-2.94%) ⬇️
commons/service-registry/src/service_ref.rs 64.87% <0.00%> (-2.70%) ⬇️
account/src/account_storage.rs 50.75% <0.00%> (-2.48%) ⬇️
... and 81 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15fc4fa...59e1939. Read the comment docs.

@github-actions
Copy link

Benchmark for d41aeef

Click to view benchmark
Test Base PR %
accumulator_append 592.0±14.44µs 599.1±14.18µs +1.20%
block_apply/block_apply_10 259.4±0.83ms 258.6±0.65ms -0.31%
block_apply/block_apply_1000 26.8±0.02s 26.4±0.03s -1.49%
get_with_proof/db_store 35.9±0.39µs 36.3±0.43µs +1.11%
get_with_proof/mem_store 31.1±0.40µs 31.6±0.44µs +1.61%
put_and_commit/db_store/1 94.9±4.86µs 95.1±4.72µs +0.21%
put_and_commit/db_store/10 849.3±42.12µs 853.9±38.63µs +0.54%
put_and_commit/db_store/100 7.3±0.28ms 7.3±0.31ms 0.00%
put_and_commit/db_store/5 433.4±22.93µs 438.2±21.47µs +1.11%
put_and_commit/db_store/50 3.8±0.18ms 3.8±0.22ms 0.00%
put_and_commit/mem_store/1 61.0±5.71µs 60.9±5.35µs -0.16%
put_and_commit/mem_store/10 566.2±45.37µs 572.0±48.04µs +1.02%
put_and_commit/mem_store/100 5.6±0.80ms 5.6±0.81ms 0.00%
put_and_commit/mem_store/5 290.3±24.82µs 289.5±25.24µs -0.28%
put_and_commit/mem_store/50 2.8±0.18ms 2.8±0.18ms 0.00%
query_block/query_block_in(10)_times(100) 3.8±0.19ms 3.9±0.14ms +2.63%
query_block/query_block_in(10)_times(1000) 38.8±0.72ms 38.3±0.95ms -1.29%
query_block/query_block_in(10)_times(10000) 387.8±4.61ms 386.8±8.13ms -0.26%
query_block/query_block_in(1000)_times(100) 948.4±7.13µs 951.6±10.28µs +0.34%
query_block/query_block_in(1000)_times(1000) 9.5±0.06ms 9.6±0.06ms +1.05%
query_block/query_block_in(1000)_times(10000) 95.6±0.76ms 94.9±0.66ms -0.73%
storage_transaction 1049.3±304.57µs 1062.6±331.63µs +1.27%
vm/transaction_execution/1 307.9±1.25ms 309.6±3.99ms +0.55%
vm/transaction_execution/10 97.4±0.80ms 96.5±0.30ms -0.92%
vm/transaction_execution/20 89.9±0.96ms 89.5±0.94ms -0.44%
vm/transaction_execution/5 118.5±1.14ms 119.6±1.76ms +0.93%
vm/transaction_execution/50 101.1±0.60ms 101.6±1.49ms +0.49%

@nanne007 nanne007 merged commit 028ce89 into master Feb 23, 2022
@nanne007 nanne007 deleted the fix_dev_package branch February 23, 2022 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants