Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enlarge max_open_files #3217

Merged
merged 3 commits into from
Feb 18, 2022
Merged

enlarge max_open_files #3217

merged 3 commits into from
Feb 18, 2022

Conversation

nkysg
Copy link
Collaborator

@nkysg nkysg commented Feb 17, 2022

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

rocksdb write IO error: Too many open files

What is the new behavior?

Other information

@nkysg nkysg requested a review from jolestar February 17, 2022 06:26
@codecov
Copy link

codecov bot commented Feb 17, 2022

Codecov Report

Merging #3217 (1c18901) into master (1712f87) will decrease coverage by 0.15%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3217      +/-   ##
==========================================
- Coverage   32.08%   31.94%   -0.14%     
==========================================
  Files         503      503              
  Lines       46374    46374              
  Branches    21279    21279              
==========================================
- Hits        14874    14809      -65     
- Misses      17424    17474      +50     
- Partials    14076    14091      +15     
Flag Coverage Δ
unittests 31.94% <0.00%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
config/src/storage_config.rs 52.39% <ø> (ø)
node/src/node.rs 10.14% <0.00%> (+0.45%) ⬆️
vm/types/src/language_storage_ext.rs 37.50% <0.00%> (-12.50%) ⬇️
vm/types/src/on_chain_config/vm_config.rs 35.00% <0.00%> (-11.66%) ⬇️
...ccount_config/resources/module_upgrade_strategy.rs 34.29% <0.00%> (-8.57%) ⬇️
abi/decoder/src/lib.rs 1.58% <0.00%> (-7.87%) ⬇️
vm/natives/src/token.rs 22.23% <0.00%> (-6.66%) ⬇️
chain/open-block/src/lib.rs 31.58% <0.00%> (-6.57%) ⬇️
state/state-store-api/src/lib.rs 43.75% <0.00%> (-6.25%) ⬇️
rpc/api/src/contract_api.rs 11.77% <0.00%> (-5.88%) ⬇️
... and 79 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1712f87...1c18901. Read the comment docs.

@github-actions
Copy link

Benchmark for ace0026

Click to view benchmark
Test Base PR %
accumulator_append 594.5±13.13µs 595.6±13.66µs +0.19%
block_apply/block_apply_10 257.8±1.70ms 258.7±1.67ms +0.35%
block_apply/block_apply_1000 26.4±0.03s 26.5±0.14s +0.38%
get_with_proof/db_store 35.7±0.31µs 36.0±0.67µs +0.84%
get_with_proof/mem_store 30.9±0.36µs 31.0±0.25µs +0.32%
put_and_commit/db_store/1 94.7±4.78µs 94.5±4.96µs -0.21%
put_and_commit/db_store/10 854.8±41.62µs 854.5±40.33µs -0.04%
put_and_commit/db_store/100 7.3±0.33ms 7.3±0.29ms 0.00%
put_and_commit/db_store/5 433.3±23.23µs 435.5±22.46µs +0.51%
put_and_commit/db_store/50 3.8±0.17ms 3.8±0.19ms 0.00%
put_and_commit/mem_store/1 61.0±5.43µs 61.3±5.57µs +0.49%
put_and_commit/mem_store/10 571.7±46.52µs 572.6±46.86µs +0.16%
put_and_commit/mem_store/100 5.6±0.80ms 5.6±0.81ms 0.00%
put_and_commit/mem_store/5 287.3±23.94µs 290.9±23.78µs +1.25%
put_and_commit/mem_store/50 2.8±0.18ms 2.8±0.18ms 0.00%
query_block/query_block_in(10)_times(100) 3.8±0.10ms 3.9±0.12ms +2.63%
query_block/query_block_in(10)_times(1000) 39.1±1.14ms 38.7±0.74ms -1.02%
query_block/query_block_in(10)_times(10000) 389.6±5.59ms 390.6±6.99ms +0.26%
query_block/query_block_in(1000)_times(100) 950.4±11.35µs 939.9±6.80µs -1.10%
query_block/query_block_in(1000)_times(1000) 9.5±0.09ms 9.4±0.09ms -1.05%
query_block/query_block_in(1000)_times(10000) 95.3±1.20ms 94.3±0.85ms -1.05%
storage_transaction 1044.9±292.42µs 1054.8±290.76µs +0.95%
vm/transaction_execution/1 306.4±1.06ms 306.4±0.96ms 0.00%
vm/transaction_execution/10 97.2±1.27ms 97.2±1.16ms 0.00%
vm/transaction_execution/20 89.4±0.96ms 89.5±0.73ms +0.11%
vm/transaction_execution/5 118.8±1.54ms 118.9±1.38ms +0.08%
vm/transaction_execution/50 100.7±0.62ms 101.0±0.53ms +0.30%

@nanne007 nanne007 merged commit 56aadba into master Feb 18, 2022
@nanne007 nanne007 deleted the fix_max_openfiles branch February 18, 2022 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants