Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix windows and non x86_64 compile warning #3180

Merged
merged 2 commits into from
Feb 10, 2022
Merged

Conversation

nkysg
Copy link
Collaborator

@nkysg nkysg commented Jan 27, 2022

No description provided.

@nkysg nkysg requested a review from sanlee42 January 27, 2022 16:19
@codecov
Copy link

codecov bot commented Jan 27, 2022

Codecov Report

Merging #3180 (bd33dfc) into master (64dd82d) will increase coverage by 0.05%.
The diff coverage is 11.12%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3180      +/-   ##
==========================================
+ Coverage   31.89%   31.93%   +0.05%     
==========================================
  Files         503      503              
  Lines       46298    46306       +8     
  Branches    21247    21255       +8     
==========================================
+ Hits        14763    14785      +22     
+ Misses      17457    17438      -19     
- Partials    14078    14083       +5     
Flag Coverage Δ
unittests 31.93% <11.12%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
consensus/cryptonight-rs/build.rs 18.19% <11.12%> (-48.48%) ⬇️
vm/types/src/language_storage_ext.rs 50.00% <0.00%> (-50.00%) ⬇️
vm/types/src/on_chain_config/vm_config.rs 35.00% <0.00%> (-11.66%) ⬇️
...ccount_config/resources/module_upgrade_strategy.rs 34.29% <0.00%> (-8.57%) ⬇️
abi/decoder/src/lib.rs 1.58% <0.00%> (-7.87%) ⬇️
rpc/api/src/contract_api.rs 11.77% <0.00%> (-5.88%) ⬇️
vm/resource-viewer/src/lib.rs 0.66% <0.00%> (-5.26%) ⬇️
rpc/server/src/module/contract_rpc.rs 3.71% <0.00%> (-3.70%) ⬇️
vm/types/src/time.rs 70.84% <0.00%> (-3.12%) ⬇️
... and 70 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64dd82d...bd33dfc. Read the comment docs.

@sanlee42 sanlee42 merged commit 3882281 into master Feb 10, 2022
@sanlee42 sanlee42 deleted the fix-cr-build-warning branch February 10, 2022 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants