Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stdlib U256 native function verification workaround #3174

Merged
merged 2 commits into from
Jan 26, 2022

Conversation

xudon9
Copy link
Contributor

@xudon9 xudon9 commented Jan 25, 2022

  • Add pragma opaque to arithmetic functions that invoke native functions;
  • Specification for them added (TODO: but doesn't seem to be used by MVP);
  • U256.md updated.

@xudon9 xudon9 linked an issue Jan 25, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jan 25, 2022

Codecov Report

Merging #3174 (69c7273) into master (6aec59d) will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3174      +/-   ##
==========================================
+ Coverage   32.08%   32.13%   +0.06%     
==========================================
  Files         503      503              
  Lines       46298    46298              
  Branches    21236    21236              
==========================================
+ Hits        14848    14873      +25     
+ Misses      17419    17195     -224     
- Partials    14031    14230     +199     
Flag Coverage Δ
unittests 32.13% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...m/types/src/account_config/events/config_change.rs 66.67% <0.00%> (-33.33%) ⬇️
consensus/src/dummy.rs 69.57% <0.00%> (-13.04%) ⬇️
vm/natives/src/vector.rs 16.67% <0.00%> (-8.33%) ⬇️
executor/src/block_executor.rs 21.28% <0.00%> (-6.38%) ⬇️
vm/types/src/on_chain_config/mod.rs 47.95% <0.00%> (-5.47%) ⬇️
state/state-tree/src/mock/mod.rs 43.48% <0.00%> (-4.34%) ⬇️
config/src/helper.rs 50.99% <0.00%> (-3.92%) ⬇️
commons/crypto/src/multi_ed25519/multi_shard.rs 42.86% <0.00%> (-3.17%) ⬇️
consensus/src/consensus.rs 58.74% <0.00%> (-3.17%) ⬇️
vm/types/src/token/stc.rs 62.86% <0.00%> (-2.85%) ⬇️
... and 68 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6aec59d...69c7273. Read the comment docs.

@jolestar jolestar merged commit 06337c2 into master Jan 26, 2022
@jolestar jolestar deleted the fix/u256-verification branch January 26, 2022 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support u256 in move prover
2 participants