Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native u256 #3032

Merged
merged 13 commits into from
Nov 25, 2021
Merged

Native u256 #3032

merged 13 commits into from
Nov 25, 2021

Conversation

nanne007
Copy link
Member

Cargo.toml Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Nov 18, 2021

Codecov Report

Merging #3032 (d1a332a) into master (26d9af0) will increase coverage by 0.17%.
The diff coverage is 13.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3032      +/-   ##
==========================================
+ Coverage   33.14%   33.30%   +0.17%     
==========================================
  Files         516      516              
  Lines       45976    46020      +44     
  Branches    20965    21019      +54     
==========================================
+ Hits        15233    15324      +91     
+ Misses      16425    16337      -88     
- Partials    14318    14359      +41     
Flag Coverage Δ
unittests 33.30% <13.47%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
vm/move-cli/src/package.rs 0.00% <ø> (ø)
vm/natives/src/u256.rs 0.00% <0.00%> (ø)
vm/natives/src/lib.rs 81.82% <87.50%> (+31.82%) ⬆️
executor/src/block_executor.rs 35.56% <0.00%> (-11.11%) ⬇️
executor/src/executor.rs 50.00% <0.00%> (-4.16%) ⬇️
vm/types/src/on_chain_config/mod.rs 50.69% <0.00%> (-4.10%) ⬇️
consensus/src/difficulty.rs 39.54% <0.00%> (-3.48%) ⬇️
...mmons/accumulator/src/inmemory/accumulator_test.rs 46.76% <0.00%> (-2.59%) ⬇️
txpool/src/pool.rs 58.34% <0.00%> (-2.38%) ⬇️
vm/types/src/token/token_code.rs 33.34% <0.00%> (-2.38%) ⬇️
... and 72 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26d9af0...d1a332a. Read the comment docs.

@nanne007 nanne007 requested a review from jolestar November 19, 2021 01:27
@nanne007 nanne007 requested a review from jolestar November 19, 2021 09:14
@nanne007 nanne007 force-pushed the native-u256 branch 2 times, most recently from c498bfc to f76dc3a Compare November 23, 2021 03:26
@nanne007 nanne007 marked this pull request as ready for review November 23, 2021 03:27
@nanne007 nanne007 requested review from welbon and wubuku November 23, 2021 03:27
@@ -231,3 +231,37 @@ starcoin-vm-runtime.debug = 1

[profile.release.package."*"]
debug = false

#[patch."https://github.com/starcoinorg/diem"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个 patch 还需要么?

@nanne007 nanne007 merged commit 65c4c39 into master Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants