Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix export and import block bug #3031

Merged
merged 7 commits into from
Nov 19, 2021
Merged

Fix export and import block bug #3031

merged 7 commits into from
Nov 19, 2021

Conversation

nkysg
Copy link
Collaborator

@nkysg nkysg commented Nov 18, 2021

1.export block use db read only
2. import block save_startup_info
3. add linux pprof import block and some print hint

1.export block use db read only
2. import block save_startup_info
3. add linux pprof import block and some print hint
@nkysg nkysg requested a review from jolestar November 18, 2021 08:51
@codecov
Copy link

codecov bot commented Nov 18, 2021

Codecov Report

Merging #3031 (a743b78) into master (7c1328f) will decrease coverage by 0.39%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3031      +/-   ##
==========================================
- Coverage   33.48%   33.10%   -0.38%     
==========================================
  Files         516      516              
  Lines       45959    45961       +2     
  Branches    20978    20966      -12     
==========================================
- Hits        15386    15212     -174     
+ Misses      16311    16303       -8     
- Partials    14262    14446     +184     
Flag Coverage Δ
unittests 33.10% <ø> (-0.38%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
executor/src/block_executor.rs 22.23% <0.00%> (-20.00%) ⬇️
commons/forkable-jellyfish-merkle/src/lib.rs 40.84% <0.00%> (-11.83%) ⬇️
vm/types/src/transaction_metadata.rs 56.93% <0.00%> (-9.23%) ⬇️
storage/src/chain_info/mod.rs 71.43% <0.00%> (-7.14%) ⬇️
sync/src/block_connector/metrics.rs 30.31% <0.00%> (-6.06%) ⬇️
commons/stream-task/src/task_stream.rs 60.30% <0.00%> (-5.88%) ⬇️
chain/src/chain.rs 39.62% <0.00%> (-5.80%) ⬇️
chain/open-block/src/lib.rs 36.37% <0.00%> (-5.19%) ⬇️
storage/src/cache_storage/mod.rs 44.00% <0.00%> (-5.00%) ⬇️
consensus/src/consensus.rs 58.74% <0.00%> (-4.76%) ⬇️
... and 71 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c1328f...a743b78. Read the comment docs.

Copy link
Member

@jolestar jolestar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

有了 db-exporter 支持 import block 后,是不是 Replay 这个 cmd 就没用了?是不是可以废弃了?

@nkysg
Copy link
Collaborator Author

nkysg commented Nov 19, 2021

应该可以废弃

remove replay from workspace
@nkysg
Copy link
Collaborator Author

nkysg commented Nov 19, 2021

需要加入进度条提示下,还有其他些修改

@nkysg nkysg merged commit b39d591 into master Nov 19, 2021
@nkysg nkysg deleted the export_import_block branch November 19, 2021 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants