Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unsave block body #2995

Merged
merged 1 commit into from
Nov 1, 2021
Merged

unsave block body #2995

merged 1 commit into from
Nov 1, 2021

Conversation

nkysg
Copy link
Collaborator

@nkysg nkysg commented Oct 28, 2021

unsave block body

unsave block body
@nkysg nkysg requested a review from jolestar October 28, 2021 13:20
@codecov
Copy link

codecov bot commented Oct 28, 2021

Codecov Report

Merging #2995 (7a6528a) into master (e50b1a5) will increase coverage by 0.35%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2995      +/-   ##
==========================================
+ Coverage   33.15%   33.50%   +0.35%     
==========================================
  Files         515      515              
  Lines       45678    45676       -2     
  Branches    20812    20810       -2     
==========================================
+ Hits        15140    15299     +159     
+ Misses      16079    16051      -28     
+ Partials    14459    14326     -133     
Flag Coverage Δ
unittests 33.50% <100.00%> (+0.35%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
storage/src/lib.rs 55.29% <ø> (+0.97%) ⬆️
storage/src/block/mod.rs 56.30% <100.00%> (+5.21%) ⬆️
test-helper/src/dummy_network_service.rs 22.23% <0.00%> (-14.81%) ⬇️
config/src/helper.rs 46.00% <0.00%> (-8.00%) ⬇️
vm/natives/src/token.rs 27.28% <0.00%> (-4.54%) ⬇️
vm/functional-tests/src/config/global.rs 43.81% <0.00%> (-4.13%) ⬇️
types/src/account_state.rs 63.34% <0.00%> (-3.33%) ⬇️
consensus/src/difficulty.rs 43.03% <0.00%> (-2.32%) ⬇️
vm/transaction-builder/src/lib.rs 28.65% <0.00%> (-1.25%) ⬇️
sync/src/tasks/mod.rs 26.47% <0.00%> (-1.23%) ⬇️
... and 69 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e50b1a5...7a6528a. Read the comment docs.

@jolestar
Copy link
Member

这个等发布版本后再合并,作为 storage 清理的一部分。

@jolestar jolestar merged commit 0f0117c into master Nov 1, 2021
@jolestar jolestar deleted the storage-perf branch November 1, 2021 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants