-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NFT gallery #2771
Merged
Merged
NFT gallery #2771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jolestar
commented
Aug 6, 2021
•
edited
Loading
edited
- 重构了 Gallery 的实现,不再依赖 Collection2,感觉 Collection2 很难有通用的设计方法。返回 NFTInfo 的 vector,用于遍历用户的 Gallery。
- 将 NFT.uid 重命名为 NFT.id ,更直接一些。uid 容易有歧义。
- withdraw_one 返回 NFT 而不是 Option
- 支持 get_nft_info_by_idx
Codecov Report
@@ Coverage Diff @@
## master #2771 +/- ##
==========================================
+ Coverage 31.80% 31.89% +0.10%
==========================================
Files 508 508
Lines 44778 44778
Branches 19929 19929
==========================================
+ Hits 14236 14278 +42
+ Misses 16643 16607 -36
+ Partials 13899 13893 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
sanlee42
approved these changes
Aug 9, 2021
Benchmark for fd2592cClick to view benchmark
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.