Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a NFT card game example #2760

Merged
merged 5 commits into from
Aug 2, 2021
Merged

Implement a NFT card game example #2760

merged 5 commits into from
Aug 2, 2021

Conversation

jolestar
Copy link
Member

@jolestar jolestar commented Aug 2, 2021

  1. 在 genesis 中自动初始化 NFT。
  2. 重构了 NFT 的 MintCapability 和 BurnCapability,这两个 Cap 只和 NFTType 相关,是全局的 Cap,和具体的用户无关。
  3. 实现了一个卡牌 NFT 的例子,两个 L1Card NFT 可以铸造一个 L2Card NFT。

@codecov
Copy link

codecov bot commented Aug 2, 2021

Codecov Report

Merging #2760 (f542bab) into master (a458320) will increase coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2760      +/-   ##
==========================================
+ Coverage   31.68%   31.82%   +0.15%     
==========================================
  Files         508      508              
  Lines       44778    44778              
  Branches    19929    19929              
==========================================
+ Hits        14183    14248      +65     
+ Misses      16814    16646     -168     
- Partials    13781    13884     +103     
Flag Coverage Δ
unittests 31.82% <ø> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
executor/src/script_function_test.rs 13.96% <0.00%> (-3.48%) ⬇️
chain/src/verifier/mod.rs 29.32% <0.00%> (-2.58%) ⬇️
vm/types/src/on_chain_resource/epoch.rs 19.38% <0.00%> (-2.32%) ⬇️
commons/timeout-join-handler/src/lib.rs 40.43% <0.00%> (-2.12%) ⬇️
...ync/src/block_connector/block_connector_service.rs 32.19% <0.00%> (-1.14%) ⬇️
...ons/forkable-jellyfish-merkle/src/node_type/mod.rs 65.30% <0.00%> (-1.03%) ⬇️
sync/src/block_connector/test_illegal_block.rs 11.63% <0.00%> (-1.02%) ⬇️
block-relayer/src/block_relayer.rs 25.61% <0.00%> (-0.60%) ⬇️
commons/service-registry/src/service_registry.rs 42.06% <0.00%> (-0.58%) ⬇️
vm/vm-runtime/src/starcoin_vm.rs 29.29% <0.00%> (-0.13%) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a458320...f542bab. Read the comment docs.

@sanlee42 sanlee42 merged commit 0f47dd4 into master Aug 2, 2021
@sanlee42 sanlee42 deleted the nft_card branch August 2, 2021 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants