[stdlib] Implement a generic Oracle data protocol #2732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2732 +/- ##
==========================================
- Coverage 31.93% 31.70% -0.23%
==========================================
Files 508 508
Lines 44774 44774
Branches 19930 19930
==========================================
- Hits 14295 14189 -106
- Misses 16500 16810 +310
+ Partials 13979 13775 -204
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Benchmark for cd2c6a0Click to view benchmark
|
nanne007
reviewed
Jul 23, 2021
| } | ||
|
|
||
| struct OracleFeed<OracleT: copy+store+drop, ValueT: copy+store+drop> has key { | ||
| record: DataRecord<ValueT>, |
There was a problem hiding this comment.
oraclefeed 里建议加上 data source id
There was a problem hiding this comment.
是在 DataRecord 里还是 OracleFeed？如果是 OracleFeed 的话感觉没必要，OracleFeed 和 DataSource 都在同一个账号下，只有一份
nanne007
reviewed
Jul 23, 2021
Benchmark for b323712Click to view benchmark
|
Benchmark for 2b7b27eClick to view benchmark
|
nanne007
approved these changes
Jul 27, 2021
Benchmark for 6acf1efClick to view benchmark
|
Benchmark for 46bfbe0Click to view benchmark
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
在 #2727 的基础上进行重构