Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autocomplete search for Android Demo App #295
Autocomplete search for Android Demo App #295
Changes from 23 commits
8f584e5
4d7fda9
616b5e4
02dd283
306a121
02bb61b
eb5a9e7
5100feb
b97d5fa
8ff64b4
10f0c72
db4c02e
afce8ff
7a84dff
5fe9eff
924ea21
8f5bec4
5f7abfb
37a4511
f81cb8a
40d6470
9e887d6
784832a
454309e
821fd8a
ea883b1
b8fc590
d5f5274
7501991
ff295fc
57e21d2
84745b0
71622fd
7510aa8
56cb38f
b9211cb
f80c494
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This behavior probably needs to go directly into the
DefaultNavigationViewModel
. Since our android implementation is still a little incorrect. In practice most architectures should only inject a single view model from their AppModule into their navigation scene/view.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably also "make this configurable" 😄.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ha! Yeah, I'm open to that if we can do it without too much work. There's a fine line between a demo app and recreating Google Maps ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can throw in a segmented button here with walking, cycling, and driving and call it a day: https://developer.android.com/reference/kotlin/androidx/compose/material3/package-summary#SingleChoiceSegmentedButtonRow(androidx.compose.ui.Modifier,androidx.compose.ui.unit.Dp,kotlin.Function1)