-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove old processed files #86
Conversation
9a69d7d
to
cd33156
Compare
Thanks @Hazannovich for this PR. I will test it and then merge it. Thanks for the PR. |
run_first.py
Outdated
|
||
logging.info('Started to read from Data/Resumes') | ||
try: | ||
# Check if there are resumes present or not. | ||
# If present then parse it. | ||
remove_old_files("Data/Processed/Resumes") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be great if we could define a macro with this string path at the global scope.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah you can add it there as well. @sanketkhajuria
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sanketkhajuria is that fine?
cd33156
to
931ae89
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Hazannovich Thanks for this mate! 💙💚
This was a much needed feature, I'm approving it and merging it as well.
Pull Request Title
Improved Data handling
Related Issue
issue #74
Description
Type
Proposed Changes
Screenshots / Code Snippets (if applicable)
How to Test
python run_first.py
would remove the existing filesChecklist
Additional Information