Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add BuildAssert support for Gradle with the Kotlin DSL #1412

Closed
wants to merge 10 commits into from
Closed

Add BuildAssert support for Gradle with the Kotlin DSL #1412

wants to merge 10 commits into from

Conversation

prithvitewatia
Copy link
Contributor

@prithvitewatia prithvitewatia commented May 16, 2023 •
edited
Loading

This PR resolves #1348 in which a build assert support for Kotlin DSL has been added.

Prithvi singh added 10 commits May 16, 2023 14:34
Refactored code: moved containsOnlyExtProperties to AbstractTextAsser…
6382b78 
…t enhances spring-iogh-1348
Added method for kotlin dsl builds enhances spring-iogh-1348
228536b
Refactored code: moved method containsOnlyExtProperties to AbstractTe…
99d38e7 
…xtAssert enhances spring-iogh-1348
Created class KotlinDslGradleBuildAssert enhances spring-iogh-1348
061fd0b
Added tests KotlinDslGradleBuildAssertTests enhances spring-iogh-1348
d9229fc
Created class KotlinDslGradleSettingsAssert enhances spring-iogh-1348
055f8b0
Added tests KotlinDslGradleSettingsAssertTests enhances spring-iogh-1348
2b4901e
Added tests for Kotlin dsl gradle build enhances spring-iogh-1348
3e1e0a7
Created sample kotlin dsl gradle build file spring-iogh-1348
a7c1d62
Created sample kotlin dsl gradle settings file spring-iogh-1348
b491a88
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 16, 2023
@prithvitewatia prithvitewatia changed the title resolves Gh 1348 Add BuildAssert support for Gradle with the Kotlin DSL resolves #1348 Add BuildAssert support for Gradle with the Kotlin DSL May 16, 2023
@snicoll snicoll mentioned this pull request Jun 12, 2023
Closed
@snicoll snicoll added type: enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Jun 12, 2023
@snicoll snicoll added this to the 0.20.0 milestone Jun 12, 2023
@snicoll snicoll self-assigned this Jun 12, 2023
@snicoll snicoll changed the title resolves #1348 Add BuildAssert support for Gradle with the Kotlin DSL Add BuildAssert support for Gradle with the Kotlin DSL Jun 12, 2023
snicoll pushed a commit that referenced this pull request Jun 12, 2023
@snicoll
Add build assertion support for Gradle with the Kotlin DSL
99415bb 
See gh-1412
snicoll added a commit that referenced this pull request Jun 12, 2023
@snicoll
Polish "Add build assertion support for Gradle with the Kotlin DSL"
c99c8c0 
See gh-1412
@snicoll snicoll closed this in 7f1208a Jun 12, 2023
@snicoll
Copy link
Contributor

snicoll commented Jun 12, 2023

@prithvitewatia thank you for making your first contribution to Spring Initializr.

@prithvitewatia
Copy link
Contributor Author

@prithvitewatia thank you for making your first contribution to Spring Initializr.

Thank you @snicoll . Although its my second. 😄

@snicoll
Copy link
Contributor

snicoll commented Jun 12, 2023

Thank you @snicoll . Although its my second. 😄

Sorry, something must be off with your account or GitHub. You're still flagged as first time contributor (see first comment on this PR).

@prithvitewatia prithvitewatia deleted the gh-1348 branch June 14, 2023 12:31
@snicoll snicoll mentioned this pull request Jul 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@snicoll snicoll

Labels
type: enhancement
Projects
None yet
Milestone
0.20.0
Development

Successfully merging this pull request may close these issues.

Add BuildAssert support for Gradle with the Kotlin DSL
3 participants
@prithvitewatia @snicoll @spring-projects-issues