Don't include org.jetbrains.kotlin:kotlin-stdlib-jdk8 as a dependency in Gradle projects at the Kotlin Gradle plugin adds the dependency automatically #1376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@KotlinIsland Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@KotlinIsland Thank you for signing the Contributor License Agreement! |
spring-projects-issues
added
the
status: waiting-for-triage
philwebb
changed the title
|
Thanks for the proposal, @KotlinIsland. Rather than making the addition conditional on the build's type, I think it would be better to move it into the Maven-specific customiser, |
wilkinsona
added
the
status: waiting-for-feedback
|
Sure. Thanks for the review |
spring-projects-issues
added
status: feedback-provided
KotlinIsland
force-pushed
the
no_kotlin_stdlib
branch
5 times, most recently
from
4fc1f71 to
b7beed1
Compare
KotlinIsland
force-pushed
the
no_kotlin_stdlib
branch
from
b7beed1 to
6622c7b
Compare
wilkinsona
changed the title
wilkinsona
added
type: enhancement
and removed
status: feedback-provided
wilkinsona
pushed a commit
that referenced
this pull request
Feb 27, 2023
wilkinsona
added a commit
that referenced
this pull request
Feb 27, 2023
|
Thanks very much, @KotlinIsland. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is legacy and Kotlin handles this automatically for Gradle builds.
https://kotlinlang.org/docs/whatsnew14.html#dependency-on-the-standard-library-added-by-default