Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement new apply method in ConfServiceInstanceProvider.Function #317

Conversation

ryanjbaxter
Copy link
Contributor

No description provided.

@ryanjbaxter ryanjbaxter requested a review from spencergibb May 31, 2023 13:08
@ryanjbaxter ryanjbaxter added this to the 3.1.4 milestone May 31, 2023
@ryanjbaxter ryanjbaxter merged commit 7347629 into spring-cloud:3.1.x Jun 13, 2023
@pantherdd
Copy link

pantherdd commented Nov 28, 2023

What was the goal of this change? There is no description, no explanation of why this was necessary, while on the other hand it broke our integration with this library. ☹️

The regression this caused is that there were ways to customize the CuratorFramework instance that got used, e.g. by injecting a CuratorFrameworkCustomizer via a registry.registerIfAbsent call in a custom BootstrapRegistryInitializer that runs before ZookeeperConfigServerBootstrapper. Such customizations worked flawlessly until version 3.1.3, but in 3.1.4 they are now silently ignored. How are people supposed to do such things now? And what's the benefit of this change?

This change should be reverted; even if it makes sense to do this, it most definitely doesn't belong in a patch release.
Thanks.


Update: opened issue #324 about this.

@pantherdd
Copy link

For the record (from #324 (comment)):

It was part of spring-cloud/spring-cloud-commons#1228 and spring-cloud/spring-cloud-config#1922

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants