-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add dbtext decompression benchmark #44
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NickCondron thanks for contributing! A few points to address, see my comments.
As I mentioned, the decompression throughput is canonically measured in bytes-out per unit time.
These are the bench results I get on my M2 Max laptop:
02b58e2
to
b74c021
Compare
I appreciate the detailed comments. I pushed your recommended changes. I never figured out how to get the only the decompression benchmarks to run, so I didn't run into that issue initially haha. |
b74c021
to
42973f2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
## 🤖 New release * `fsst-rs`: 0.4.3 -> 0.4.4 (✓ API compatible changes) <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [0.4.4](v0.4.3...v0.4.4) - 2024-12-30 ### Added - add dbtext decompression benchmark (#44) ### Other - Decode into an uninitialized byte slice ([#63](#63)) - *(deps)* lock file maintenance (#62) - *(deps)* lock file maintenance (#60) - *(deps)* lock file maintenance (#59) - *(deps)* update mozilla-actions/sccache-action action to v0.0.7 (#58) - *(deps)* lock file maintenance (#57) - *(deps)* lock file maintenance (#56) - *(deps)* lock file maintenance (#55) - *(deps)* lock file maintenance (#54) - *(deps)* lock file maintenance (#53) - *(deps)* lock file maintenance (#50) - *(deps)* lock file maintenance (#49) - *(deps)* lock file maintenance (#47) - *(deps)* lock file maintenance (#46) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/release-plz/release-plz/). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
decompress_into
function the memory could be reused and this wouldn't be an issue.