Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove tool.maturin #18

Merged
merged 1 commit into from
Feb 16, 2023
Merged

fix: remove tool.maturin #18

merged 1 commit into from
Feb 16, 2023

Conversation

Mikcl
Copy link
Contributor

@Mikcl Mikcl commented Feb 16, 2023 •
edited
Loading

Fix: Did not mean to commit this.

The project still builds but will give you an ImportError at runtime, as described here: https://github.com/PyO3/maturin#mixed-rustpython-projects with the correct stucture/fix.

sansyrox
sansyrox approved these changes Feb 16, 2023
View reviewed changes
Copy link
Member

@sansyrox sansyrox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Mikcl ❇️

I have been setting up automated builds recently. So, didn't really notice 😅

@sansyrox sansyrox merged commit f5b3ea2 into sparckles:main Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sansyrox sansyrox sansyrox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mikcl @sansyrox