Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: load the last starfyre if we can #16

Merged
merged 1 commit into from
Feb 16, 2023

Conversation

Mikcl
Copy link
Contributor

@Mikcl Mikcl commented Feb 16, 2023

Error in the test-application when installing a newer starfyre wheel.

Updated to just install the latest if we can. we're in development afterall.

File "/lib/python3.10/site-packages/micropip/_micropip.py", line 364, in check_version_satisfied
    raise ValueError(
ValueError: Requested 'starfyre<0.4.0,>=0.3.0', but starfyre==0.4.1 is already installed

Docs on version constraints which were causing this:
https://python-poetry.org/docs/dependency-specification/

@Mikcl Mikcl mentioned this pull request Feb 16, 2023
Copy link
Member

@sansyrox sansyrox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Mikcl 😄

LGTM!

@sansyrox sansyrox merged commit 905c15c into sparckles:main Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants