Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: changing vendor for a stack is no longer allowed #574

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

TheMacies
Copy link
Contributor

@TheMacies TheMacies commented Oct 23, 2024

Description of the change

Backend does not allow it anymore. One of the tests used this feature so we need to refactor it.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (non-breaking change that adds documentation)

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development
  • Examples for new resources and data sources have been added
  • Default values have been documented in the description (e.g., "Dummy: (Boolean) Blah blah. Defaults to false.)
  • If the action fails that checks the documentation: Run go generate to make sure the docs are up to date

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • Pull Request is no longer marked as "draft"
  • Reviewers have been assigned
  • Changes have been reviewed by at least one other engineer

@TheMacies TheMacies force-pushed the fix-vendorchanging-tests branch 2 times, most recently from 7903359 to 167ad89 Compare October 23, 2024 07:39
@TheMacies TheMacies force-pushed the fix-vendorchanging-tests branch from 167ad89 to e776d14 Compare October 23, 2024 08:31
@TheMacies TheMacies requested a review from truszkowski October 23, 2024 08:57
@TheMacies TheMacies merged commit bdff95d into main Oct 23, 2024
7 checks passed
@TheMacies TheMacies deleted the fix-vendorchanging-tests branch October 23, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants